Fix PHP 8 fatal in avatar cache key when $id_or_email is an object#447
Open
polevaultweb wants to merge 1 commit into
Open
Fix PHP 8 fatal in avatar cache key when $id_or_email is an object#447polevaultweb wants to merge 1 commit into
polevaultweb wants to merge 1 commit into
Conversation
…object Derives a safe scalar cache key from any input type instead of concatenating $id_or_email directly, which throws on PHP 8 when the value is an object without __toString(). Fixes #443 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Fixes a PHP 8+ fatal in WPUM_Avatars::set_default_avatar() by ensuring the transient cache key is derived safely when $id_or_email is passed as an object (e.g., WP_Comment / WP_User) via WordPress’ get_avatar_url filter.
Changes:
- Replaces direct string concatenation of
$id_or_emailinto the transient key with object-aware key derivation. - Adds support for deriving the key from comment IDs, user IDs, or email-derived hashes, with a JSON-hash fallback.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+207
to
+219
| if ( is_object( $id_or_email ) ) { | ||
| if ( ! empty( $id_or_email->comment_ID ) ) { | ||
| $key_part = 'c' . $id_or_email->comment_ID; | ||
| } elseif ( ! empty( $id_or_email->ID ) ) { | ||
| $key_part = 'u' . $id_or_email->ID; | ||
| } elseif ( ! empty( $id_or_email->user_email ) ) { | ||
| $key_part = md5( $id_or_email->user_email ); | ||
| } else { | ||
| $key_part = md5( wp_json_encode( $id_or_email ) ); | ||
| } | ||
| } else { | ||
| $key_part = (string) $id_or_email; | ||
| } |
Comment on lines
+207
to
+209
| if ( is_object( $id_or_email ) ) { | ||
| if ( ! empty( $id_or_email->comment_ID ) ) { | ||
| $key_part = 'c' . $id_or_email->comment_ID; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Object could not be converted to string) inWPUM_Avatars::set_default_avatar()when$id_or_emailis aWP_CommentorWP_Userobjectget_avatar()Fixes #443
Test plan
🤖 Generated with Claude Code