OpenCV installer with contrib modules#11
Open
N-kelkay wants to merge 2 commits intoWPIRoboticsProjects:masterfrom
Open
OpenCV installer with contrib modules#11N-kelkay wants to merge 2 commits intoWPIRoboticsProjects:masterfrom
N-kelkay wants to merge 2 commits intoWPIRoboticsProjects:masterfrom
Conversation
Member
|
@SamCarlberg I want your thoughts on this. This is kinda your project. |
Member
|
@N-kelkay Thanks for the first time contribution! We'll take a look! |
Author
|
Thanks for replying, I am just waiting for approval. If you need more detail I am happy to explain some more. |
Author
|
Hey! its been more then 2 weeks since we chatted. At this point I understand that you guys don't want to accept my pull request, but thats fine. Thanks anyway. |
Member
|
@SamCarlberg Can you please take a look at this? |
Member
|
IMO, this PR is out-of-scope for this project. This is a cross-platform installer for the builds of OpenCV by WPILib, mostly for tests of generated OpenCV pipelines from GRIP. It's not meant to do local platform-specific builds and installs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! My name is Natenael, I added a new folder called "installOpencvWithModules". It is for those who want to use opencv to work with ArUco and ChArUco boards. I just thought it would be helpful.