style(Computer Avatar Selector): Improve selection flow#2293
Open
hirokiterashima wants to merge 1 commit intodevelopfrom
Open
style(Computer Avatar Selector): Improve selection flow#2293hirokiterashima wants to merge 1 commit intodevelopfrom
hirokiterashima wants to merge 1 commit intodevelopfrom
Conversation
|
Coverage Impact Unable to calculate total coverage change because base branch coverage was not found. 🚦 See full report on Qlty Cloud »🛟 Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This change is inspired by a feedback from one of the masters students. It improves the computer avatar selection flow and lessens the likelihood that the student will skip the dialog guidance activity altogether.
Notes
Please style as you see fit. It'd be nice to make the view of the selected avatar a little bit more fun(?)/exciting(?) somehow, like how users select a character when they're playing a video game. Maybe use text/image animations to make the selected avatar pop, without being overwhelming?
There may be some old styles that we can remove due to this change.
Changes
Test