feat(Teacher Tools): Important activities#2292
Open
hirokiterashima wants to merge 8 commits intodevelopfrom
Open
feat(Teacher Tools): Important activities#2292hirokiterashima wants to merge 8 commits intodevelopfrom
hirokiterashima wants to merge 8 commits intodevelopfrom
Conversation
…contains a component with important tag
hirokiterashima
added
the
enhancement
❌ 4 blocking issues (4 total)
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
| (icon: any) => (icon as Element).textContent.trim() === 'star' | ||
| ) as any; | ||
| } | ||
| expect(starIcon).toBeTruthy(); |
| (icon: any) => (icon as Element).textContent.trim() === 'star' | ||
| ) as any; | ||
| } | ||
| expect(starIcon).toBeFalsy(); |
| const icons = Array.from(fixture.nativeElement.querySelectorAll('mat-icon')); | ||
| const starIcon = icons.find((icon: any) => icon.textContent.trim() === 'star'); | ||
| expect(starIcon).toBeTruthy(); | ||
| expect(component['hasImportantComponent']).toBeTrue(); |
| const icons = Array.from(fixture.nativeElement.querySelectorAll('mat-icon')); | ||
| const starIcon = icons.find((icon: any) => icon.textContent.trim() === 'star'); | ||
| expect(starIcon).toBeFalsy(); | ||
| expect(component['hasImportantComponent']).toBeFalse(); |
|
Coverage Impact Unable to calculate total coverage change because base branch coverage was not found. Modified Files with Diff Coverage (5)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new feature allows teachers to quickly see important activities in the Teacher Tools. To implement this, we add an "!important" tag to an activity. These activities appear with a star icon in the teacher tools, in the step listing page and in the activities tabs in the step grading page.
Notes
Please style as you see fit.
Changes
Test