Skip to content

vmauth: prevent from appending target_path_suffix multiple times#2104

Merged
vrutkovs merged 2 commits into
masterfrom
vmauth-fixed-target-path-suffix-append
May 11, 2026
Merged

vmauth: prevent from appending target_path_suffix multiple times#2104
vrutkovs merged 2 commits into
masterfrom
vmauth-fixed-target-path-suffix-append

Conversation

@AndrewChubatiuk
Copy link
Copy Markdown
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Apr 25, 2026

Summary by cubic

Fixes vmauth URL map generation to stop appending target_path_suffix more than once. The suffix is now applied exactly once per target URL, including with static.urls and named refs.

  • Bug Fixes
    • Append static.urls to existing prefixes instead of replacing them, preventing duplicate suffixes.
    • Expanded tests for named and CRD refs, unauthorized users, and static multi-URL targets to assert single-suffix behavior.
    • Updated CHANGELOG.

Written for commit 0c8cec0. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docs/CHANGELOG.md">

<violation number="1" location="docs/CHANGELOG.md:20">
P2: Custom agent: **Changelog Review Agent**

New changelog entry is missing mandatory issue/PR references and does not meet the required user-centric before/now/improvement structure.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

Comment thread docs/CHANGELOG.md

* BUGFIX: [converter](https://docs.victoriametrics.com/operator/integrations/prometheus/#objects-conversion): disable all prometheus controllers if CRD group was not found. See [#2838](https://github.com/VictoriaMetrics/helm-charts/issues/2838).
* BUGFIX: [vmdistributed](https://docs.victoriametrics.com/operator/resources/vmdistributed/): change default load balancing policy for write requests from `first_available` to `least_loaded`. This should allow to evenly distribute write load across all VMAgents.
* BUGFIX: [vmauth](https://docs.victoriametrics.com/operator/resources/vmauth/): fixed case, when target_path_suffix can be appended multiple times.
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Custom agent: Changelog Review Agent

New changelog entry is missing mandatory issue/PR references and does not meet the required user-centric before/now/improvement structure.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/CHANGELOG.md, line 20:

<comment>New changelog entry is missing mandatory issue/PR references and does not meet the required user-centric before/now/improvement structure.</comment>

<file context>
@@ -17,6 +17,7 @@ aliases:
 
 * BUGFIX: [converter](https://docs.victoriametrics.com/operator/integrations/prometheus/#objects-conversion): disable all prometheus controllers if CRD group was not found. See [#2838](https://github.com/VictoriaMetrics/helm-charts/issues/2838).
 * BUGFIX: [vmdistributed](https://docs.victoriametrics.com/operator/resources/vmdistributed/): change default load balancing policy for write requests from `first_available` to `least_loaded`. This should allow to evenly distribute write load across all VMAgents.
+* BUGFIX: [vmauth](https://docs.victoriametrics.com/operator/resources/vmauth/): fixed case, when target_path_suffix can be appended multiple times.
 
 ## [v0.69.0](https://github.com/VictoriaMetrics/operator/releases/tag/v0.69.0)
</file context>
Fix with Cubic

Signed-off-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
@vrutkovs vrutkovs merged commit f858d28 into master May 11, 2026
4 checks passed
@vrutkovs vrutkovs deleted the vmauth-fixed-target-path-suffix-append branch May 11, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants