Fix the two Linux tests the inline key change broke - #765
Merged
Conversation
Both encoded the folding that is now platform dependent, and both are in DiffEngineViewer.Tests, which is the one test project the Linux legs of CI build. I checked DiffEngine.Tests for this and stopped there. EnqueueKeyIgnoresPathCase asserts that two paths differing only in case are one entry, which is true where the file system says so and false on Linux. It is pinned to Windows now, with the Linux half beside it asserting the two entries that platform should give. IpcTests.List snapshotted keys derived from mixed case paths, so the snapshot said which platform it ran on. Its paths are lower case now, so the key is the same text everywhere and the snapshot is back to pinning the shape of a listing. Checked by forcing the folding off and running the viewer tests: List passes, and two case-differing paths do produce the two entries the new test expects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both encoded the folding that is now platform dependent, and both are in DiffEngineViewer.Tests, which is the one test project the Linux legs of CI build. I checked DiffEngine.Tests for this and stopped there.
EnqueueKeyIgnoresPathCase asserts that two paths differing only in case are one entry, which is true where the file system says so and false on Linux. It is pinned to Windows now, with the Linux half beside it asserting the two entries that platform should give.
IpcTests.List snapshotted keys derived from mixed case paths, so the snapshot said which platform it ran on. Its paths are lower case now, so the key is the same text everywhere and the snapshot is back to pinning the shape of a listing.
Checked by forcing the folding off and running the viewer tests: List passes, and two case-differing paths do produce the two entries the new test expects.