Skip to content

fix: stop prompting basic analysts to call tools they lack - #184

Merged
ethancjackson merged 1 commit into
mainfrom
fix/analyst-prompt-tool-mismatch
Aug 6, 2026
Merged

fix: stop prompting basic analysts to call tools they lack#184
ethancjackson merged 1 commit into
mainfrom
fix/analyst-prompt-tool-mismatch

Conversation

@ethancjackson

Copy link
Copy Markdown
Collaborator

Summary

  • Basic WTI/BoC analyst configs attach no tools, but shared system prompts told the model to call search_web (and hard-required set_model_response), which can produce silent empty turns in adk web when the model attempts unavailable tools.
  • Split search guidance into supplements appended only by news-capable factories (same pattern as the existing code-exec / forecast-tool supplements).
  • Softened structured-output wording to “if set_model_response is available… otherwise return plain JSON,” matching the multitask prompt.

Test plan

  • Confirm build_wti_basic_config().instruction / build_boc_basic_config().instruction contain no search_web
  • Confirm news configs still include search guidance + recommended queries (WTI) / verification-failure handling (BoC)
  • uv run adk web implementations/energy_oil_forecasting/analyst_agent — ask a search-like question on basic; expect a text reply (no silent blank turn from a missing-tool call)
  • Spot-check a news-config predictor path still instructs search_web before forecasting

Made with Cursor

Shared WTI/BoC analyst instructions referenced search_web (and hard-required
set_model_response) even for no-tool basic configs, which can yield silent
empty turns in adk web when the model tries unavailable tools. Move search
guidance into supplements appended only by news-capable factories, and soften
SMR wording to the if-available / else plain-JSON pattern.

Co-authored-by: Cursor <cursoragent@cursor.com>
@ethancjackson
ethancjackson merged commit a29e879 into main Aug 6, 2026
@ethancjackson
ethancjackson deleted the fix/analyst-prompt-tool-mismatch branch August 6, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant