pipewire: keep the capture size the consumer asked for - #2371
Open
matte-schwartz wants to merge 1 commit into
Open
pipewire: keep the capture size the consumer asked for#2371matte-schwartz wants to merge 1 commit into
matte-schwartz wants to merge 1 commit into
Conversation
The optional requested capture size is parsed into a zero-initialised struct and assigned to the cap unconditionally. It is also advertised with a zero default, so renegotiation can clear the consumer's cap and restore full-size frames. Advertise the current request as the default and seed the parse with it. Clear the request and advertise uncapped formats when the last consumer unlinks, preserving the cap through pauses and renegotiation.
matte-schwartz
force-pushed
the
pipewire-requested-size-fix
branch
from
September 5, 2026 00:56
e48efe0 to
711e9ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The requested capture size is an optional field parsed into a zero-initialised struct, and it's assigned to the cap unconditionally. A format that omits it clears the cap, after which no downscale happens and the stream carries frames at the full output size.
Advertise the current requested size as the range default and seed the parse with it instead.