Fix stack-buffer-overflow in Windows thread-naming RaiseException (x64) - #420
Open
subhramit wants to merge 1 commit into
Open
Fix stack-buffer-overflow in Windows thread-naming RaiseException (x64)#420subhramit wants to merge 1 commit into
subhramit wants to merge 1 commit into
Conversation
Signed-off-by: subhramit <subhramit.bb@live.in>
Author
|
cc @zpostfacto if you could take a look. |
This comment was marked as duplicate.
This comment was marked as duplicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #418
On x64,
sizeof(DWORD)(4) !=sizeof(ULONG_PTR)(8), sosizeof(info)/sizeof(DWORD)evaluates to 6, causingRaiseExceptionto read 48 bytes from the 24-byteTHREADNAME_INFOon the stack.MSVC AddressSanitizer correctly halts on this, so it is harmless at runtime (the extra bytes are valid stack, and
__exceptswallows the exception), but it is an out-of-bounds read, so needed patching.Change: used
sizeof(ULONG_PTR)as the divisor, which is the form given in Microsoft's own documentation and produces the correct count on both x86 and x64.