Initialize the colors handed to OnSpecialLineColors - #3
Open
TetzkatLipHoka wants to merge 1 commit into
Open
Conversation
FullRowColors declares SpecialFG/SpecialBG as plain locals and passes them straight into DoOnSpecialLineColors as var parameters, uninitialized. A handler is allowed to set only one of the two - the other one then keeps whatever happened to be on the stack, which in practice renders as black. Normal text does not show it because the highlighter colours it; only the fallback used for a special line does. They are now seeded the way the classic SynEdit does it (Font.Color and Color). Under an active VCL style those two properties are not the colours the control is actually drawn with, so the styled colours are taken there instead, each gated on the matching StyleElements flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FullRowColors declares SpecialFG/SpecialBG as plain locals and passes them
straight into DoOnSpecialLineColors as var parameters, uninitialized. A
handler is allowed to set only one of the two - the other one then keeps
whatever happened to be on the stack, which in practice renders as black.
Normal text does not show it because the highlighter colours it; only the
fallback used for a special line does.
They are now seeded the way the classic SynEdit does it (Font.Color and
Color). Under an active VCL style those two properties are not the colours
the control is actually drawn with, so the styled colours are taken there
instead, each gated on the matching StyleElements flag.
Built with 13.1.
🤖 Generated with Claude Code