Skip to content

[k2] add separate memory for coroutines - #1675

Open
LLirikkkk wants to merge 44 commits into
masterfrom
kkotliar/k2_add_coroutine_memory
Open

[k2] add separate memory for coroutines#1675
LLirikkkk wants to merge 44 commits into
masterfrom
kkotliar/k2_add_coroutine_memory

Conversation

@LLirikkkk

@LLirikkkk LLirikkkk commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@LLirikkkk LLirikkkk self-assigned this Aug 11, 2026
@LLirikkkk LLirikkkk added optimization Memory comsumption / CPU speedup runtime Feature related to runtime k2 Affects compiler or runtime in K2 mode labels Aug 11, 2026
@LLirikkkk LLirikkkk added this to the next milestone Aug 11, 2026
@LLirikkkk
LLirikkkk marked this pull request as ready for review August 14, 2026 10:03
@LLirikkkk
LLirikkkk requested a review from apolyakov August 14, 2026 10:03
apolyakov
apolyakov requested changes Aug 18, 2026
View reviewed changes
Comment thread runtime-common/core/allocator/details/malloc-interface.h Outdated
Comment thread runtime-common/core/allocator/details/malloc-interface.h Outdated
Comment thread runtime-common/core/allocator/details/pool-allocator.h Outdated
Comment thread runtime-common/core/allocator/details/pool-allocator.h Outdated
Comment thread runtime-common/core/allocator/runtime-allocator.h
Comment thread runtime-common/core/allocator/script-malloc-interface.h Outdated
Comment thread runtime-common/core/allocator/script-malloc-interface.h Outdated
Comment thread runtime-light/components/confdata/state/instance-state.h
apolyakov
apolyakov reviewed Aug 21, 2026
View reviewed changes
Comment thread runtime-common/core/allocator/pool-allocator.h
Comment thread runtime-common/core/allocator/global-memory.h Outdated
Comment thread runtime-common/core/allocator/global-memory.h Outdated
Comment thread runtime-common/core/allocator/global-memory.h Outdated
Comment thread runtime-common/core/allocator/details/pool-allocator.h Outdated
Comment thread runtime-light/components/kphp/state/image-state.h Outdated
Comment thread runtime-light/coroutine/event.h Outdated
@LLirikkkk
LLirikkkk force-pushed the kkotliar/k2_add_coroutine_memory branch from 80eed40 to a784e3b Compare August 21, 2026 17:28
apolyakov
apolyakov previously approved these changes Aug 27, 2026
View reviewed changes

@apolyakov apolyakov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LLirikkkk added 18 commits August 28, 2026 14:41
@LLirikkkk
implement coroutine allocator
1eb2f51
@LLirikkkk
apply code style
010f460
@LLirikkkk
move coroutine-allocator into kphp::coro namespace
c36df43
@LLirikkkk
add noexcept to methods in coroutine-allocator
f461b20
@LLirikkkk
add coroutine-allocator to cmake
e13c308
@LLirikkkk
add coroutine malloc interface
621cc9e
@LLirikkkk
remove excess include in control-block
7a72bc7
@LLirikkkk
rename coroutine-allocator to runtime-coroutine-allocator
21794fc
@LLirikkkk
add std-like wrapper for coroutine-allocator
3334814
@LLirikkkk
add runtime-coroutine-allocator to coroutine-instance-state
e9658f1
@LLirikkkk
move coroutines related data to coroutine memory
613a3fa
@LLirikkkk
add default values and parsing of args for runtime-coroutine-allocator
dff1028
@LLirikkkk
add includes
1039fff
@LLirikkkk
change default values for memory size
968cc7a
@LLirikkkk
enlarge extra-coroutine-memory-pool-size value to 4MB
035a926
@LLirikkkk
small fixes
fb5d405
@LLirikkkk
add methods to allocate global memory for coroutines
4a75337
@LLirikkkk
reduce code duplication
c8056d5
LLirikkkk added 26 commits August 28, 2026 14:41
@LLirikkkk
add definitions of methods into runtime-allocator
f021453
@LLirikkkk
replace inheritance with composition
8bc1124
@LLirikkkk
add copyright header
dd8b9d2
@LLirikkkk
add get_memory_resource method into runtime-allocator and runtime-cor…
dcaa9ce 
…outine-allocator
@LLirikkkk
add sources to cmake
ff1e1cb
@LLirikkkk
revert replacing script allocator with coroutine allocator in stdlib …
b455322 
…files
@LLirikkkk
revert some more changes in stdlib files
09180d6
@LLirikkkk
revert some more changes in stdlib files
d3237d3
@LLirikkkk
small fixes
67dd85f
@LLirikkkk
add global-memory-allocator
b84b13e
@LLirikkkk
delete redundant file
4db5012
@LLirikkkk
fix compilation error
f8339f9
@LLirikkkk
replace GlobalMemoryAllocator with free functions
2224ab0
@LLirikkkk
add sources to cmake
45e86c9
@LLirikkkk
refactor coroutine memory
2184933
@LLirikkkk
fix compilation error
1d16007
@LLirikkkk
fix compilation error
f74e967
@LLirikkkk
fix compilation error
048e8ce
@LLirikkkk
rename size constants
7351660
@LLirikkkk
rename size constants
248206a
@LLirikkkk
fix heap buffer overflow in platfrom malloc interface
cbf393f
@LLirikkkk
rename arguments in coroutine-state
fd1009c
@LLirikkkk
replace runtime-coroutine-allocator with pool-allocator in coroutine-…
0d27849 
…state
@LLirikkkk
add noexcept to default constructor of pool-allocator
1f35525
@LLirikkkk
add noexcept spec
209e819
@LLirikkkk
revert add noexcept spec
70693cc
@LLirikkkk
LLirikkkk force-pushed the kkotliar/k2_add_coroutine_memory branch from ecb0f1f to 70693cc Compare August 28, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apolyakov apolyakov apolyakov left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@LLirikkkk LLirikkkk

Labels

k2 Affects compiler or runtime in K2 mode optimization Memory comsumption / CPU speedup runtime Feature related to runtime

Projects

None yet

Milestone

next

Development

Successfully merging this pull request may close these issues.

2 participants

@LLirikkkk @apolyakov