Skip to content

chore: asmdef guid references #4152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NoelStephensUnity wants to merge 3 commits into
base: develop-3.x.x
Choose a base branch
from
Open

chore: asmdef guid references #4152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
110bc18
chore: reference the Netcode for Entities assemblies by GUID
NoelStephensUnity Sep 4, 2026
eef6f9d
chore: rename the internal NetworkMetrics to ToolsNetworkMetrics
NoelStephensUnity Sep 4, 2026
46223c5
Merge branch 'develop-3.x.x' into chore/asmdef-guid-references
NoelStephensUnity Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions com.unity.netcode.gameobjects/Editor/Unity.Netcode.Editor.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"Unity.Networking.Transport",
"Unity.Services.Core",
"Unity.Services.Authentication",
"Unity.NetCode",
"Unity.NetCode.Editor"
"GUID:953adc2a6b8b4e3c8df5b728bcd546e9",
"GUID:eb8cf780bf058694ebf7ec5cf5b8cfa3"
],
"includePlatforms": [
"Editor"
Expand Down
2 changes: 1 addition & 1 deletion com.unity.netcode.gameobjects/Runtime/Metrics/NetworkMetricsManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public void Initialize(NetworkManager networkManager)
if (NetworkMetrics == null)
{
#if MULTIPLAYER_TOOLS
NetworkMetrics = new NetworkMetrics();
NetworkMetrics = new ToolsNetworkMetrics();
#else
NetworkMetrics = new NullNetworkMetrics();
#endif
Expand Down
10 changes: 6 additions & 4 deletions ...objects/Runtime/Metrics/NetworkMetrics.cs → ...ts/Runtime/Metrics/ToolsNetworkMetrics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,22 @@

namespace Unity.Netcode
{
internal class NetworkMetrics : INetworkMetrics
internal class ToolsNetworkMetrics : INetworkMetrics
{
private const ulong k_MaxMetricsPerFrame = 1000L;
private static readonly Dictionary<uint, string> k_SceneEventTypeNames;
private static readonly ProfilerMarker k_FrameDispatch;

static NetworkMetrics()
static ToolsNetworkMetrics()
{
k_SceneEventTypeNames = new Dictionary<uint, string>();
foreach (SceneEventType type in Enum.GetValues(typeof(SceneEventType)))
{
k_SceneEventTypeNames[(uint)type] = type.ToString();
}
k_FrameDispatch = new ProfilerMarker($"{nameof(NetworkMetrics)}.DispatchFrame");
// Spelled out rather than nameof: this is the name shown in the Profiler, and it
// should not move because the implementing type was renamed.
k_FrameDispatch = new ProfilerMarker("NetworkMetrics.DispatchFrame");
}

private static string GetSceneEventTypeName(uint typeCode)
Expand Down Expand Up @@ -85,7 +87,7 @@ private static string GetSceneEventTypeName(uint typeCode)

private ulong m_NumberOfMetricsThisFrame;

public NetworkMetrics()
public ToolsNetworkMetrics()
{
Dispatcher = new MetricDispatcherBuilder()
.WithCounters(m_TransportBytesSent, m_TransportBytesReceived)
Expand Down
0 ...ts/Runtime/Metrics/NetworkMetrics.cs.meta → ...ntime/Metrics/ToolsNetworkMetrics.cs.meta
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion com.unity.netcode.gameobjects/Runtime/Unity.Netcode.Runtime.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"Unity.Collections",
"Unity.Burst",
"Unity.Mathematics",
"Unity.NetCode",
"GUID:953adc2a6b8b4e3c8df5b728bcd546e9",
"Unity.Entities"
],
"includePlatforms": [],
Expand Down
2 changes: 1 addition & 1 deletion com.unity.netcode.gameobjects/Tests/Runtime/Unity.Netcode.Runtime.Tests.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"Unity.Mathematics",
"UnityEngine.TestRunner",
"UnityEditor.TestRunner",
"Unity.NetCode",
"GUID:953adc2a6b8b4e3c8df5b728bcd546e9",
"Unity.Entities"
],
"includePlatforms": [],
Expand Down