CHANGE: Removing InputSystem icons from scene view window - #2480
Conversation
josepmariapujol-unity
changed the title
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Harness Review
The change adds editor icon metadata to the three targeted component types and records the Scene view icon update in the changelog. I examined the referenced assets, their importer metadata, and the package’s existing icon/gizmo assignment paths.
Reviewed commit 29b1085
🤖 Helpful? 👍/👎
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2480 +/- ##
===========================================
- Coverage 78.95% 78.94% -0.01%
===========================================
Files 767 767
Lines 140780 140914 +134
===========================================
+ Hits 111153 111251 +98
- Misses 29627 29663 +36 Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@josepmariapujol-unity is this the full port? There were changes in the tests folder in the original too that are missing here |
Pauliusd01
left a comment
Pauliusd01
left a comment
There was a problem hiding this comment.
Noticed one file missing from original but otherwise fine
True: that specific file is auto-generated in |
2 participants
Description
Backport: Removing InputSystem icons from scene view window.
Testing status & QA
Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.