FIX: Input Actions editor losing selection when the control picker opens - #2479
Merged
Conversation
josepmariapujol-unity
changed the title
josepmariapujol-unity
changed the title
Collaborator
|
It's missing CHANGELOG.md entry btw |
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Harness Review
The change preserves state across project-wide action-editor rebuilds while refreshing the analytics session. I examined the rebuild lifecycle, state-copy remapping, action-change notifications, and editor teardown.
Reviewed commit c401f4b
🤖 Helpful? 👍/👎
Collaborator
|
Possibly dumb question but why is it so different from the original? Is this the right port? |
josepmariapujol-unity
changed the title
josepmariapujol-unity
changed the title
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #2479 +/- ##
=========================================
Coverage 78.95% 78.96%
=========================================
Files 767 767
Lines 140780 140914 +134
=========================================
+ Hits 111153 111271 +118
- Misses 29627 29643 +16 Flags with carried forward coverage won't be shown. Click here to find out more.
|
Pauliusd01
reviewed
Sep 8, 2026
jfreire-unity
approved these changes
Sep 8, 2026
Pauliusd01
reviewed
Sep 8, 2026
Pauliusd01
self-requested a review
September 8, 2026 12:33
Pauliusd01
approved these changes
Sep 8, 2026
Collaborator
Author
|
Test failing unrelated to this pr |
Collaborator
Author
|
I'll fix CI in another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of [UUM-150809] Fix Input Actions editor losing selection when the control picker opens #123382
https://github.cds.internal.unity3d.com/unity/unity/pull/123382
Testing status & QA
N/A
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.