CHANGE: Fixing warnings after updating editor (Player Input warning)

[josepmariapujol-unity]

Description

Fixing warning after updating editor to 6000.5:

Packages/com.unity.inputsystem/InputSystem/Plugins/PlayerInput/PlayerInput.cs(813,16): warning CS0109: The member 'PlayerInput.camera' does not hide an accessible member. The new keyword is not required.

JIRA: UUM-135199

Slack: https://unity.slack.com/archives/C04RDRXRJ1L/p1771861581262009

Testing status & QA

Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

• Complexity: 0
• Halo Effect: 0

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

• Changelog entry added.
  • Explains the change in Changed, Fixed, Added sections.
  • For API change contains an example snippet and/or migration example.
  • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
  • Jira port for the next release set as "Resolved".
• Tests added/changed, if applicable.
  • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
  • Performance tests.
  • Integration tests.
• Docs for new/changed API's.
  • Xmldoc cross references are set correctly.
  • Added explanation how the API works.
  • Usage code examples added.
  • The manual is updated, if needed.

During merge:

• Commit message for squash-merge is prefixed with one of the list:
  • NEW: ___.
  • FIX: ___.
  • DOCS: ___.
  • CHANGE: ___.
  • RELEASE: 1.1.0-preview.3.

[u-pr]

PR Reviewer Guide 🔍

(Review updated until commit 2f07167)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪ The PR consists of very small and straightforward changes to fix compiler warnings.

🏅 Score: 90 The changes correctly resolve the warnings, but backward compatibility for older Unity versions should be verified.

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Backward Compatibility Removing the new keyword avoids a warning (CS0109) in newer Unity versions where Component.camera has been completely removed. However, if this package still supports older Unity versions where the base property still exists, this change might introduce a CS0108 warning (hides inherited member). Ensure this aligns with the minimum supported Unity version of the package, or use Unity version preprocessor directives (e.g., #if UNITY_202X_X_OR_NEWER) to selectively apply the new keyword if older versions are still supported. public Camera camera { get => m_Camera; set => m_Camera = value; }

Update review

---

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr

[u-pr]

PR Code Suggestions ✨

No code suggestions found for the PR.

[codecov-github-com]

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff            @@
##           develop    #2354   +/-   ##
========================================
  Coverage    77.89%   77.90%           
========================================
  Files          476      476           
  Lines        97613    97613           
========================================
+ Hits         76036    76042    +6     
+ Misses       21577    21571    -6     

Flag	Coverage Δ
inputsystem_MacOS_2022.3	5.53% <ø> (ø)
inputsystem_MacOS_2022.3_project	75.39% <ø> (ø)
inputsystem_MacOS_6000.0	5.30% <ø> (ø)
inputsystem_MacOS_6000.0_project	77.30% <ø> (+<0.01%)	⬆️
inputsystem_MacOS_6000.3	5.31% <ø> (ø)
inputsystem_MacOS_6000.3_project	77.29% <ø> (+<0.01%)	⬆️
inputsystem_MacOS_6000.4	5.31% <ø> (ø)
inputsystem_MacOS_6000.4_project	77.30% <ø> (ø)
inputsystem_MacOS_6000.5	5.31% <ø> (ø)
inputsystem_MacOS_6000.5_project	77.30% <ø> (ø)
inputsystem_MacOS_6000.6	5.31% <ø> (ø)
inputsystem_MacOS_6000.6_project	77.30% <ø> (-0.01%)	⬇️
inputsystem_Ubuntu_2022.3	5.53% <ø> (ø)
inputsystem_Ubuntu_2022.3_project	75.19% <ø> (ø)
inputsystem_Ubuntu_6000.0	5.31% <ø> (ø)
inputsystem_Ubuntu_6000.0_project	77.09% <ø> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.3	5.31% <ø> (ø)
inputsystem_Ubuntu_6000.3_project	77.10% <ø> (+<0.01%)	⬆️
inputsystem_Ubuntu_6000.4	5.32% <ø> (ø)
inputsystem_Ubuntu_6000.4_project	77.10% <ø> (ø)
inputsystem_Ubuntu_6000.5	5.32% <ø> (ø)
inputsystem_Ubuntu_6000.5_project	77.11% <ø> (+<0.01%)	⬆️
inputsystem_Ubuntu_6000.6	5.32% <ø> (ø)
inputsystem_Ubuntu_6000.6_project	77.10% <ø> (ø)
inputsystem_Windows_2022.3	5.53% <ø> (ø)
inputsystem_Windows_2022.3_project	75.52% <ø> (ø)
inputsystem_Windows_6000.0	5.30% <ø> (ø)
inputsystem_Windows_6000.0_project	77.42% <ø> (-0.01%)	⬇️
inputsystem_Windows_6000.3	5.31% <ø> (ø)
inputsystem_Windows_6000.3_project	77.42% <ø> (ø)
inputsystem_Windows_6000.4	5.31% <ø> (ø)
inputsystem_Windows_6000.4_project	77.42% <ø> (-0.01%)	⬇️
inputsystem_Windows_6000.5	5.31% <ø> (ø)
inputsystem_Windows_6000.5_project	77.42% <ø> (ø)
inputsystem_Windows_6000.6	5.31% <ø> (ø)
inputsystem_Windows_6000.6_project	77.43% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...tem/InputSystem/Plugins/PlayerInput/PlayerInput.cs	89.18% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[u-pr]

Persistent review updated to latest commit 2f07167

[u-pr]

PR Code Suggestions ✨

No code suggestions found for the PR.

[ekcoh]

Thanks for correcting this!