ci: run checks and publish on release branches - #1879
Merged
Conversation
Hotfix releases are cut on release/* branches, but both workflows are scoped to main: - ci.yml only fires for PRs targeting main, so a PR into a release branch gets no checks. The branch ruleset covers refs/heads/release/* and requires lint, commit-lint, Sonar and the test matrix, so those contexts sit at Expected forever and the PR cannot merge without a bypass. - cd.yml only fires on push to main, so merging a hotfix publishes nothing and every release needs a manual workflow_dispatch. Publishing stays safe: detect_publishable_packages.py only emits packages whose version is absent from PyPI, so a push to a release branch that does not bump a version publishes nothing.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Pull request overview
This PR updates the GitHub Actions CI and CD workflows so they also run on release/** branches, aligning workflow triggers with the project’s hotfix/release branching procedure and required status checks.
Changes:
- Extend
.github/workflows/ci.ymltriggers so CI runs for PRs targeting and pushes torelease/**in addition tomain. - Extend
.github/workflows/cd.ymltriggers so publish automation runs on pushes torelease/**(still gated bypackages/*/pyproject.tomlpath filters).
File summaries
| File | Description |
|---|---|
| .github/workflows/ci.yml | Adds release/** to pull_request and push branch filters so required CI checks run on release branches. |
| .github/workflows/cd.yml | Adds release/** to the push branch filter so publishing can occur from release branches when package versions change. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
ionut-mihalache-uipath
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Scopes both workflows to
release/**in addition tomain.# ci.yml pull_request: branches: - main + - 'release/**' push: branches: - main + - 'release/**' # cd.yml push: branches: - main + - 'release/**' paths: - 'packages/*/pyproject.toml'Why
Hotfix releases are cut on
release/*branches, per the open-source hotfix procedure, but both workflows are scoped tomainonly.Checks never run.
ci.ymlfires only for PRs targetingmain. TheActionsruleset coversrefs/heads/release/*and requireslint / Lint,commit-lint / Commit Lint,SonarCloud Code Analysisand the sixtest / Test (...)contexts. For a PR into a release branch, nothing produces them, so all of them sit atExpected — Waiting for status to be reportedindefinitely and the PR is unmergeable without an admin bypass. The ruleset requires checks the workflow config cannot emit for that base.Publishing never happens.
cd.ymlfires only on push tomain, so merging a hotfix into its release branch publishes nothing and every release needs a manualworkflow_dispatch. A manual dispatch also runs the workflow file from the dispatched ref, which for a branch cut from an older commit means running an older CI definition thanmain's.Is auto-publishing from a release branch safe
Yes.
detect_publishable_packages.pycompares eachpackages/*/pyproject.tomlversion against PyPI and emits only versions that 404, so a push to a release branch that does not bump a version publishes nothing. The publish step also passesskip-existing: true. Thepypienvironment has no deployment branch policy, so a release ref is already permitted to publish.release/*is covered by theActionsruleset, which requires a pull request, so nothing reaches these branches unreviewed.Known limitation
This does not retroactively fix a hotfix branch cut from a commit that predates the
uipath-ubuntu-latestrunner rename. Such a branch produces contexts namedtest / Test (3.11, ubuntu-latest), which do not match the names the ruleset requires, so those PRs still need a bypass or a workflow sync. This change is what stops the problem recurring for branches cut from here on.