Skip to content

fix(ui5-side-navigation): align indication tag with new spec - #14200

Merged
s-todorova merged 6 commits into
mainfrom
tag-updates-sidenav
Oct 28, 2026
Merged

s-todorova merged 6 commits into
mainfrom
tag-updates-sidenav

Conversation

@s-todorova

Copy link
Copy Markdown
Contributor

Align the SideNavigation indication tag with the updated Fiori spec and sap.tnt reference across all modes:

  • Render the tag inline after the item text in a shared text-tag container; wrap it to a second line when it does not fit.
  • Keep vertical breathing room when the tag wraps by using block padding on the item (min-height stays the single-line floor), in both the expanded list and the collapsed-rail picker popover.
  • Show the full tag inline in the collapsed popover and keep it on a single line in the collapsed rail flyout (truncated at 6rem).
  • Align the overflow menu item tag and keep item height stable.
  • Do not highlight tag text on search; describe items via an invisible 'Tag {text}' string.

Align the SideNavigation indication tag with the updated Fiori spec and
sap.tnt reference across all modes:

- Render the tag inline after the item text in a shared text-tag
  container; wrap it to a second line when it does not fit.
- Keep vertical breathing room when the tag wraps by using block padding
  on the item (min-height stays the single-line floor), in both the
  expanded list and the collapsed-rail picker popover.
- Show the full tag inline in the collapsed popover and keep it on a
  single line in the collapsed rail flyout (truncated at 6rem).
- Align the overflow menu item tag and keep item height stable.
- Do not highlight tag text on search; describe items via an invisible
  'Tag {text}' string.

Adds functional and visual tests and a parity test page.
@s-todorova
s-todorova deployed to netlify-preview October 23, 2026 13:03 — with GitHub Actions Active
@sap-ui5-webcomponents-release

Copy link
Copy Markdown

@s-todorova
s-todorova requested a review from a team October 26, 2026 07:10
@s-todorova
s-todorova deployed to netlify-preview October 26, 2026 10:31 — with GitHub Actions Active
@s-todorova
s-todorova deployed to netlify-preview October 26, 2026 15:11 — with GitHub Actions Active
@s-todorova
s-todorova deployed to netlify-preview October 27, 2026 09:59 — with GitHub Actions Active
@s-todorova
s-todorova deployed to netlify-preview October 27, 2026 13:40 — with GitHub Actions Active
@s-todorova
s-todorova deployed to netlify-preview October 28, 2026 07:18 — with GitHub Actions Active
@s-todorova
s-todorova merged commit 1fac660 into main Oct 28, 2026
34 of 37 checks passed
@s-todorova
s-todorova deleted the tag-updates-sidenav branch October 28, 2026 13:24
@s-todorova
s-todorova deployed to netlify-preview October 28, 2026 13:24 — with GitHub Actions Active
@sap-ui5-webcomponents-release

Copy link
Copy Markdown

🧹 Preview deployment cleaned up: https://pr-14200--ui5-webcomponents.netlify.app

This branch was successfully deployed

1 active deployment
netlify-preview — 71241efc Deployed Oct 28, 2026 by s-todorova via cleanup-preview #733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants