Skip to content

build: update pnpm to v12 - #204

Closed
dangreen wants to merge 1 commit into
build/node-26from
build/pnpm-12
Closed

dangreen wants to merge 1 commit into
build/node-26from
build/pnpm-12

Conversation

@dangreen

@dangreen dangreen commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Why

pnpm 12 is the latest release, one major past the 11.9.0 the repository was on, while CI ran 11.11.0. Its breaking changes leave the workspace alone: pnpm 12 recognizes every setting of pnpm-workspace.yaml, nothing passes --frozen-lockfile false, no dependency comes from git, and engineStrict is off. The one change it asks for is in the lockfile: pnpm 12, like pnpm 11.28, compares the publishConfig.linkDirectory of a package with the lockfile, so a frozen install of the old lockfile fails with ERR_PNPM_OUTDATED_LOCKFILE.

What

  • .tool-versions pins pnpm 12.9.1, the version of the latest tag.
  • Every pnpm/action-setup step asks for pnpm 12; v6 of the action supports it.
  • The lockfile records linkDirectory: false for the 8 packages whose publishConfig sets it, the way pnpm 12 writes it, and nothing else. pnpm 12 finds it up to date with these lines alone, and a plain install changes nothing.

Notes

@coveralls

coveralls commented Oct 6, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 37490810327

Warning

No base build found for commit 373adb4 on build/node-26.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 69.769%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 1046
Covered Lines: 725
Line Coverage: 69.31%
Relevant Branches: 211
Covered Branches: 152
Branch Coverage: 72.04%
Branches in Coverage %: Yes
Coverage Strength: 10.93 hits per line

💛 - Coveralls

Pin pnpm 12.9.1 and ask CI for pnpm 12. Settings need no migration from pnpm 11. The lockfile
records `linkDirectory: false` of the 8 packages that set it, which a frozen install of pnpm 12
checks, and pnpm 12 finds it up to date with that alone.
@dangreen

dangreen commented Oct 6, 2026

Copy link
Copy Markdown
Member Author

Folded into #203, which now carries the pnpm 12 update as well.

@dangreen dangreen closed this Oct 6, 2026
@dangreen
dangreen deleted the build/pnpm-12 branch October 6, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants