Repository navigation
Conversation
Coverage Report for CI Build 37490810327Warning No base build found for commit Coverage: 69.769%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
Pin pnpm 12.9.1 and ask CI for pnpm 12. Settings need no migration from pnpm 11. The lockfile records `linkDirectory: false` of the 8 packages that set it, which a frozen install of pnpm 12 checks, and pnpm 12 finds it up to date with that alone.
dangreen
force-pushed
the
build/pnpm-12
branch
from
October 6, 2026 15:49
73447b1 to
2f88946
Compare
Member
Author
|
Folded into #203, which now carries the pnpm 12 update as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
pnpm 12 is the latest release, one major past the 11.9.0 the repository was on, while CI ran 11.11.0. Its breaking changes leave the workspace alone: pnpm 12 recognizes every setting of
pnpm-workspace.yaml, nothing passes--frozen-lockfile false, no dependency comes from git, andengineStrictis off. The one change it asks for is in the lockfile: pnpm 12, like pnpm 11.28, compares thepublishConfig.linkDirectoryof a package with the lockfile, so a frozen install of the old lockfile fails withERR_PNPM_OUTDATED_LOCKFILE.What
.tool-versionspins pnpm 12.9.1, the version of thelatesttag.pnpm/action-setupstep asks for pnpm 12; v6 of the action supports it.linkDirectory: falsefor the 8 packages whosepublishConfigsets it, the way pnpm 12 writes it, and nothing else. pnpm 12 finds it up to date with these lines alone, and a plain install changes nothing.Notes
.tool-versions. Once build: update Node.js to v26 and pnpm to v12 #203 is merged, this branch gets rebased ontomain, which also runs theChecksworkflow that covers pull requests intomainalone.minimumReleaseAgehas applied since pnpm 11, so the move to 12 changes nothing about it, andminimumReleaseAgeExcludestays as it is.pnpm run, which triggers no install before the script, the unit tests and lint of core, andlint-package-jsonthroughpnpm dlx.