Repository navigation
Feedback drops empty-stamped messages; stamp deserialization sorts - #823
Merged
frankmcsherry merged 1 commit intoOct 16, 2026
Merged
Conversation
The feedback edge now drops a message whose advanced stamp is empty, including messages that arrive with empty stamps. Previously those were forwarded, and could circulate a loop unseen by progress tracking. The docs and comment now say that the edge maps capabilities only, and that advancing times carried by contents is the container's job. Deserializing a `Stamp` sorts its elements, as the bytes need not come from a valid `Stamp`. This adds a `T: Ord` bound where stamps are deserialized. Also corrects the `Event::Messages` doc, which called the stamp an antichain, and notes that `Stamp` equality compares multisets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the timely items from Materialize's report on the differential
master-nextport.Changes
This now includes messages that arrive with empty stamps, which were previously forwarded and could circulate a loop unseen by progress tracking.
Advancing times carried by contents, and discarding those that cannot advance, is the container's job (as differential's
ResultsIndoes beforeconnect_loop).The previous comment claimed that contents supported only by discarded stamp elements were not sent, which the code did not do.
Stampsorts its elements, as the bytes need not come from a validStamp.This adds a
T: Ordbound toStamp'sDeserialize,Event'sDeserialize,Message'sBytesable, andEventReader'sEventIterator.Event::Messagesdoc no longer calls the stamp an antichain.Stamp's doc notes that equality compares multisets:{a}and{a, a}differ.Not included
CapabilitySetderefs to[Capability<T>], socaps.iter().map(|c| c.time())already borrows.Columnarderive onStamp.Tests
progress::stamp::tests::deserialize_sortstests/stamps.rs::zero_capability_stamps_feedback, which fails on the previous behavior.🤖 Generated with Claude Code