Conversation
Ground rules: - Latest LTS is tested fully - Every other supported LTS (currently only 21) is tested on one platform only - Latest release (currently 27) is tested as much as possible Other principles: - Disable fail-fast where we're not limited by cost; we want to see results from all JDKs, even if some fail. - Fix concurrency groups so that jobs don't self-cancel.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Java 21 is still tested on two platforms, violating the one-platform rule for non-current LTS coverage.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Standardizes CI coverage across JDK 21, 25, and 27 while preventing matrix jobs from cancelling one another.
Changes:
- Adds JDK 27 and expands multi-JDK testing.
- Updates concurrency groups and disables matrix fail-fast.
- Expands secure, quickstart, and downstream coverage.
File summaries
| File | Summary |
|---|---|
.github/workflows/pull_request.yml |
Updates Java and native-image matrices; Java 21 remains configured on two platforms. |
.github/workflows/pull_request_secure.yml |
Adds expanded secure JDK coverage. |
.github/workflows/pull_request_quickstarts.yml |
Adds JDK 25 and 27 quickstart testing. |
.github/workflows/downstream_build.yml |
Adds JDK 25 and 27 downstream testing. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rsynek
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ground rules:
Other principles: