Problem 061 Project Euler#14798
Conversation
algorithms-keeper
Bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
| """ | ||
|
|
||
| def triangle(n: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file project_euler/problem_061/sol1.py, please provide doctest for the function triangle
Please provide descriptive name for the parameter: n
|
|
||
| """ | ||
|
|
||
| def square(n: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file project_euler/problem_061/sol1.py, please provide doctest for the function square
Please provide descriptive name for the parameter: n
|
|
||
| """ | ||
|
|
||
| def pentagon(n: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file project_euler/problem_061/sol1.py, please provide doctest for the function pentagon
Please provide descriptive name for the parameter: n
|
|
||
| """ | ||
|
|
||
| def hexagon(n: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file project_euler/problem_061/sol1.py, please provide doctest for the function hexagon
Please provide descriptive name for the parameter: n
|
|
||
| """ | ||
|
|
||
| def heptagon(n: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file project_euler/problem_061/sol1.py, please provide doctest for the function heptagon
Please provide descriptive name for the parameter: n
|
|
||
| """ | ||
|
|
||
| def octagon(n: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file project_euler/problem_061/sol1.py, please provide doctest for the function octagon
Please provide descriptive name for the parameter: n
| return arr | ||
|
|
||
|
|
||
| def check_cyclic(x: int, y: int) -> bool: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
Please provide descriptive name for the parameter: y
algorithms-keeper
Bot
removed
require descriptive names
diusazzad
left a comment
diusazzad
left a comment
There was a problem hiding this comment.
Could you rename them to something more descriptive (like number1 and number2 or similar) to make the code even clearer for others?
The functions like triangle, square, etc., look great! Just double-checking if you've added a sample test case for each to ensure the doctests pass successfully.
Everything else looks solid.
|
If you check the latest commit for the PR, I have added doctest for all functions like triangle, square etc. |
2 participants
Describe your change:
Added solution of problem 061 of Project Euler.
Checklist: