Refactor binary to decimal conversion function#14571
Open
Ewanjohndennis wants to merge 2 commits intoTheAlgorithms:masterfrom
Open
Refactor binary to decimal conversion function#14571Ewanjohndennis wants to merge 2 commits intoTheAlgorithms:masterfrom
Ewanjohndennis wants to merge 2 commits intoTheAlgorithms:masterfrom
Conversation
Rewrote bin_to_decimal to use Python's built-in int(s, 2) instead of a manual loop that accumulates the decimal value digit by digit. The logic and doctests are unchanged. Also added a guard for "-" as input, which previously slipped past the empty-string check and raised an unhelpful ValueError about non-binary values.
for more information, see https://pre-commit.ci
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrote
bin_to_decimalto use Python's built-inint(s, 2)instead of a manual loop that accumulates the decimal value digit by digit. The logic and doctests are unchanged. Also added a guard for"-"as input, which previously slipped past the empty-string check and raised an unhelpfulValueErrorabout non-binary values.Describe your change:
Checklist: