Skip to content

Fix empty error message for pyramid side length - #7723

Draft
Axsasf wants to merge 2 commits into
TheAlgorithms:masterfrom
Axsasf:new_branch
Draft

Axsasf wants to merge 2 commits into
TheAlgorithms:masterfrom
Axsasf:new_branch

Conversation

@Axsasf

@Axsasf Axsasf commented Nov 2, 2026

Copy link
Copy Markdown

Description

Fixed an empty IllegalArgumentException message in the surfaceAreaPyramid method of Area.java.

Changes Made

  • Replaced the empty exception message with "Must be a positive sideLength".
  • Improved the error message when the side length is zero or negative.
  • Left the remaining functionality unchanged.

@codecov-commenter

codecov-commenter commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.22%. Comparing base (8b49bc5) to head (8e2bbc0).

Files with missing lines Patch % Lines
src/main/java/com/thealgorithms/maths/Area.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #7723      +/-   ##
============================================
- Coverage     82.23%   82.22%   -0.01%     
  Complexity     8402     8402              
============================================
  Files           843      843              
  Lines         26140    26140              
  Branches       5100     5100              
============================================
- Hits          21495    21493       -2     
- Misses         3853     3854       +1     
- Partials        792      793       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

if (slantHeight <= 0) {
throw new IllegalArgumentException("slant height must be greater than 0");
}
if (sideLength <= 0) {

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated validation messages clearly explain that both sideLength and slantHeight must be positive. This makes invalid input errors easier to understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants