Skip to content

fix(table-core): honor explicit global filter opt-in#6439

Draft
KevinVandy wants to merge 1 commit into
betafrom
agent/fix-4673-explicit-global-filter
Draft

fix(table-core): honor explicit global filter opt-in#6439
KevinVandy wants to merge 1 commit into
betafrom
agent/fix-4673-explicit-global-filter

Conversation

@KevinVandy

Copy link
Copy Markdown
Member

Summary

  • let an explicit per-column global-filter opt-in bypass the default primitive-value heuristic
  • preserve table-wide filtering controls and custom column eligibility predicates
  • cover object-valued custom global filtering at the capability and row-model levels

Rationale

By default, global filtering still only opts primitive string and number accessor values in automatically. When a column explicitly sets enableGlobalFilter to true, however, rejecting it with that same heuristic is surprising and prevents a custom globalFilterFn from handling object or array values. This change treats the explicit flag as an override of only the built-in heuristic; custom getColumnCanGlobalFilter policies remain authoritative.

Validation

  • 48 focused Vitest tests passed
  • table-core TypeScript check passed
  • ESLint passed for changed files
  • Prettier check passed for changed files
  • git diff --check passed

Closes #4673

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 17270835-3d70-4612-bc39-8edcf782d4e3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/fix-4673-explicit-global-filter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jul 18, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 5dce30e

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 8m 47s View ↗
nx run-many --targets=build --exclude=examples/** ✅ Succeeded 51s View ↗

☁️ Nx Cloud last updated this comment at 2026-07-18 00:38:50 UTC

@pkg-pr-new

pkg-pr-new Bot commented Jul 18, 2026

Copy link
Copy Markdown
More templates

@tanstack/alpine-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/alpine-table@6439

@tanstack/angular-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table@6439

@tanstack/angular-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table-devtools@6439

@tanstack/ember-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/ember-table@6439

@tanstack/lit-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/lit-table@6439

@tanstack/match-sorter-utils

npm i https://pkg.pr.new/TanStack/table/@tanstack/match-sorter-utils@6439

@tanstack/preact-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table@6439

@tanstack/preact-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table-devtools@6439

@tanstack/react-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table@6439

@tanstack/react-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table-devtools@6439

@tanstack/solid-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table@6439

@tanstack/solid-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table-devtools@6439

@tanstack/svelte-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/svelte-table@6439

@tanstack/table-core

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-core@6439

@tanstack/table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-devtools@6439

@tanstack/vue-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table@6439

@tanstack/vue-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table-devtools@6439

commit: 5dce30e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Global filter doesn't run when accessor key points to an object

1 participant