fix(table-core): honor explicit global filter opt-in#6439
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 5dce30e
☁️ Nx Cloud last updated this comment at |
Summary
Rationale
By default, global filtering still only opts primitive string and number accessor values in automatically. When a column explicitly sets enableGlobalFilter to true, however, rejecting it with that same heuristic is surprising and prevents a custom globalFilterFn from handling object or array values. This change treats the explicit flag as an override of only the built-in heuristic; custom getColumnCanGlobalFilter policies remain authoritative.
Validation
Closes #4673