chore: update knip by TkDodo · Pull Request #11262 · TanStack/query

TkDodo · 2026-08-23T11:37:16Z

Summary by CodeRabbit

Chores
- Updated internal code-quality tooling and its configuration.
- Improved configuration-file scanning and validation rules.
- Refreshed development tooling used during automated checks.
- Strengthened automated checks for configuration-related issues.
Refactor
- Reduced exposure of several internal TypeScript types without changing their behavior or constraints.
- No user-facing functionality or API behavior was changed.

coderabbitai · 2026-08-23T11:37:39Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4e3431cd-cb34-4d17-85ea-de9cd7d68770

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ceb947c3-fa85-42d0-9069-a5185cbcc67e

📥 Commits

Reviewing files that changed from the base of the PR and between 923565f and b5e65fa.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (1)

package.json

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

Knip now checks root-level configuration files and treats configuration and tag hints as errors. The Knip dependency and test script were updated. Three internal type declarations are no longer exported.

Changes

Knip and type visibility cleanup

Layer / File(s)	Summary
Knip configuration and version update `knip.json`, `package.json`	Knip now checks root configuration files and treats configuration and tag hints as errors. The development dependency and `test:knip` command were updated.
Internal type visibility cleanup `packages/lit-query/src/createQueriesController.ts`, `packages/preact-query/src/__tests__/ErrorBoundary/types.ts`	`CreateQueriesOptions` and three `ErrorBoundaryProps` variants remain structurally unchanged but are no longer exported.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to b5e65

This dependency and configuration update has no actionable merge-blocking risk based on the available evidence and is merge-ready after normal checks and review.

Suggested reviewers: sheraff

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided, so the required changes, checklist, and release impact sections are missing.	Add the required sections and describe the Knip changes, test status, and whether the change affects published code.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely identifies the primary change: updating the Knip configuration and dependency.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch tkdodo/chore/update-knip

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

nx-cloud · 2026-08-23T11:37:42Z

View your CI Pipeline Execution ↗ for commit f177b59

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	8m 47s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	44s	View ↗

☁️ Nx Cloud last updated this comment at 2026-08-23 16:57:54 UTC

github-actions · 2026-08-23T11:38:23Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

socket-security · 2026-08-23T11:39:48Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	knip@6.32.2

View full report

pkg-pr-new · 2026-08-23T16:50:30Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11262

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11262

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11262

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11262

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11262

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11262

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11262

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11262

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11262

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11262

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11262

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11262

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11262

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11262

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11262

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11262

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11262

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11262

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11262

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11262

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11262

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11262

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11262

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11262

commit: f177b59

github-actions · 2026-08-23T16:51:46Z

size-limit report 📦

Path	Size
react full	11.97 KB (0%)
react minimal	8.92 KB (0%)

chore: update knip

dd9bbe3

ref: move cli options to config options

923565f

TkDodo added 2 commits August 23, 2026 13:47

fix package lock somehow

b5e65fa

pnpm dedupe

f177b59

TkDodo merged commit f2a5da2 into main Aug 23, 2026
9 checks passed

TkDodo deleted the tkdodo/chore/update-knip branch August 23, 2026 17:24

Navigation Menu

Uh oh!

Uh oh!

chore: update knip - #11262

chore: update knip#11262
TkDodo merged 4 commits into
mainfrom
tkdodo/chore/update-knip

TkDodo commented Aug 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 23, 2026 •

edited

Loading

Review skipped

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

nx-cloud Bot commented Aug 23, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 23, 2026

Uh oh!

socket-security Bot commented Aug 23, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Aug 23, 2026

Uh oh!

github-actions Bot commented Aug 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

TkDodo commented Aug 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

nx-cloud Bot commented Aug 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 23, 2026

🚀 Changeset Version Preview

Uh oh!

socket-security Bot commented Aug 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Aug 23, 2026

Uh oh!

github-actions Bot commented Aug 23, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

TkDodo commented Aug 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 23, 2026 •

edited

Loading

nx-cloud Bot commented Aug 23, 2026 •

edited

Loading

socket-security Bot commented Aug 23, 2026 •

edited

Loading