fix({preact,solid,svelte,angular-query-experimental}): switch to 'export type *' for type-only re-exports - #11251
Open
sukvvon wants to merge 2 commits into
Open
fix({preact,solid,svelte,angular-query-experimental}): switch to 'export type *' for type-only re-exports#11251sukvvon wants to merge 2 commits into
sukvvon wants to merge 2 commits into
Conversation
…ort type *' for type-only re-exports
…reference from changeset body
|
View your CI Pipeline Execution ↗ for commit f25263f
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version Preview10 package(s) bumped directly, 15 bumped as dependents. 🟨 Minor bumps
🟩 Patch bumps
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe adapter package entry points now use ChangesAdapter type exports
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change removes unnecessary runtime re-exports while preserving the published type surface; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Port #11228 (react-query) to the other adapters whose
types.tsis pure type-only: changeexport * from './types'toexport type * from './types'inpreact-query,solid-query,svelte-query(types.jsonly —context.jsstill re-exports runtime functions, left unchanged), andangular-query-experimental.Under this repo's
isolatedModules: true,export *from a type-only module cannot be safely elided by the compiler and is preserved as a real runtime import.export type *is erased entirely. Verified locally:preact-queryandsvelte-query: build output drops a realimport "./types.js"/export * from './types.js'before vs. after this change.solid-queryandangular-query-experimental: their bundlers (single-file tsdown bundle, vite/rollup) already tree-shook this away, so build output is unchanged — this is a source-level correctness fix for those two, not a measured bundle-size win..d.tsoutput forpreact-queryis unchanged in the set of exported identifiers (each gains atypeprefix only); a minimal consumer repro confirms this has no effect on how types are imported/used downstream.✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit
Bug Fixes
Chores