Skip to content

chore(svelte-query/vite.config): enable coverage collection by default#10151

Open
sukvvon wants to merge 1 commit intoTanStack:mainfrom
sukvvon:chore/svelte-query-enable-coverage
Open

chore(svelte-query/vite.config): enable coverage collection by default#10151
sukvvon wants to merge 1 commit intoTanStack:mainfrom
sukvvon:chore/svelte-query-enable-coverage

Conversation

@sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Feb 18, 2026

🎯 Changes

Re-enable coverage collection for svelte-query, which was disabled during the runes rewrite in #9694.

All other query packages (react-query, solid-query, preact-query, vue-query, query-core) have coverage enabled by default.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Chores
    • Improved test coverage reporting configuration for development builds.

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2026

⚠️ No Changeset found

Latest commit: f388f66

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 18, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

This pull request enables test coverage collection in the Vitest configuration for the svelte-query package by toggling the coverage.enabled setting from false to true. Istanbul is used to measure coverage for files matching the src/**/* pattern.

Changes

Cohort / File(s) Summary
Test Coverage Configuration
packages/svelte-query/vite.config.ts
Enabled coverage reporting in vitest config by setting coverage.enabled to true, allowing Istanbul to collect coverage metrics for source files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A switch flipped, a config turned bright,
Coverage reports now shining in sight,
Tests measured true, Istanbul keeps score,
Svelte-query knows what it's made for! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: enabling coverage collection in the svelte-query vite config, which is the core modification in this PR.
Description check ✅ Passed The description follows the template structure with all required sections completed: Changes section explains the re-enablement with context, Checklist items are marked as completed, and Release Impact correctly marks as docs/CI/dev-only.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Feb 18, 2026

View your CI Pipeline Execution ↗ for commit f388f66

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-18 14:16:36 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 18, 2026

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10151

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10151

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10151

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10151

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10151

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10151

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10151

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10151

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10151

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10151

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10151

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10151

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10151

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10151

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10151

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10151

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10151

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10151

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10151

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10151

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10151

commit: f388f66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments