Open
Conversation
🦋 Changeset detectedLatest commit: 0fd1efb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Recently been using the oxc lint and formatting toolchains on my projects. They are close to supporting most common eslint plugins natively with support for the majority of the eslint js API. I wanted to add oxlint and oxfmt as tooling option in the
@tanstack/clibuilder tool, and since the eslint option used the tanstack/config eslint package I thought that starting here would be a good stepping stone before adding it as an option in the builder CLIInfo about rule changes
Rules not to be implemented
no-octal- Superseded by strict mode: ☂️ eslint core oxc-project/oxc#479Rules awaiting implementation
no-shadow@typescript-eslint/method-signature-style@typescript-eslint/naming-convention- This needs type-aware linting and is discussed if will be implemented or not@typescript-eslint/no-unnecessary-condition- Not listed in the tracking issue: ☂️ typescript-eslint oxc-project/oxc#2180Rules requiring extra TypeScript-native package
TypeScript native (tsgo) is not released yet, so decided to not include these rules as they also require the user to add an extra oxlint-tsgolint
@typescript-eslint/no-for-in-array@typescript-eslint/no-unnecessary-type-assertion@typescript-eslint/require-await🎯 Changes
Adds a new oxlint-config package that can be used just like the eslint-config package.
It's almost a one-to-one copy of the
@tanstack/eslint-configpackage with some rules omitted due to missing implementations.Usage:
As far as i know does not support the
.oxlintrc.jsonformat.✅ Checklist
pnpm test:pr.🚀 Release Impact