Fix AI Insert opening new window when no tabs are open#638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When no tabs are open ("No tabs open" empty state) and the user clicks "Insert" on an AI chat code block, it incorrectly opened a new native window tab instead of creating a query tab in the current window. This also caused the right sidebar to switch from AI Chat to Details pane (since new windows initialize with
.detailsas the default).Root cause:
insertQueryFromAI()was missing the empty-tabs check thatnewTab()already has. WhentabManager.tabsis empty, it fell through toWindowOpener.shared.openNativeTab().Fix: Added
else if tabManager.tabs.isEmptybranch that callstabManager.addTab()directly — matching the existingnewTab()pattern.Test plan