Fix idle ping spin loop from exhausted AsyncStream iterator#637
Merged
Fix idle ping spin loop from exhausted AsyncStream iterator#637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the root cause of #618 (excessive idle ping traffic, ~30 pings/second instead of 1 per 30s).
Root cause
The health monitor used a task group to race
Task.sleep(30s)againstAsyncStream.Iterator.next():When the 30s sleep won,
group.cancelAll()cancelled the wake-up task, causingnext()to returnnil. An AsyncStream iterator that returnsnilis permanently exhausted — all subsequentnext()calls returnnilinstantly. This turned the monitoring loop into a spin loop.Fix
Removed the AsyncStream + task group race entirely. Replaced with a simple
Task.sleeploop:The
checkNow()early wake-up method was dead code (never called anywhere in the codebase), so the AsyncStream mechanism served no purpose.Also added diagnostic logging to the ping handler for ongoing monitoring.
Closes #618
Test plan
ConnectionHealthMonitor)