perf: concurrent schema fetch, memoize highlighting, cap tables#634
Merged
perf: concurrent schema fetch, memoize highlighting, cap tables#634
Conversation
…debug log for fetch errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
3 performance fixes for the AI system — the final phase of the AI audit.
P2: Concurrent schema fetch with TaskGroup
for table in tablesToFetchloop withwithTaskGroupschemaProvider(actor) anddriverare both safe for concurrent accessP4: Memoize code block syntax highlighting
@Statecache for highlightedAttributedStringinAIChatCodeBlockViewcurrentHighlight()helper returns cached result when delta is smallP9b: Cap tables before fetch in SQLSchemaProvider
SQLSchemaProvider.buildSchemaContextForAI()now caps tomaxSchemaTablesBEFORE the column fetch loopbuildSchemaSection()capped to 20 — wasting thousands of DB callsArray(tables.prefix(settings.maxSchemaTables))Test plan