Modernise and align API with FastAPI idiomatic patterns#22
Merged
Conversation
…eaders in docker, switch to pydantic models, remove devgoldyutils and typing extensions and modernize and clean up everything else (quite big I know)
…onstants, move books api section to separate router and make programming books class a dependency
Owner
Author
|
I've done a lot of changes so I'll need to test run this for a while before I push it to docker hub. In theory nothing should have changed from the client facing side (all api wrappers and client should just work). I didn't touch any responses on purpose. I'm new to using |
…move `--build-arg ARCH=amd64`
Owner
Author
|
Should merge this soon. |
Owner
Author
|
Okay merging this now, I'll do a github and docker release later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slowapilibrary withfastapi-limiterfor rate limiting (this was a blocker while making the code more idiomatic).GIT_REPO_xenvironment variables as it makes no sense to even use them.uvandty) to improve maintainability.devgoldyutilsandtyping-extensions.tyandruffcheck workflows.