Skip to content

fix: logging into Renku#49

Open
olevski wants to merge 2 commits intomainfrom
fix-missing-tls-for-oidc
Open

fix: logging into Renku#49
olevski wants to merge 2 commits intomainfrom
fix-missing-tls-for-oidc

Conversation

@olevski
Copy link
Member

@olevski olevski commented Mar 4, 2026

Withtout the rustls-tls feature for the openidconnect the login command fails

olevski added 2 commits March 4, 2026 14:01
Withtout the rustls-tls feature for the openidconnect the login command
fails
@olevski olevski requested a review from eikek March 5, 2026 09:38

[features]
default = ["reqwest/default-tls"] # link against system library
rustls = ["reqwest/rustls-tls", "openidconnect/rustls-tls"] # include rustls, ssl library written in rust
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the dependency is actually there, I'm not sure what hasn't been working?

Copy link
Member Author

@olevski olevski Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eikek on my computer (linux, fedora, amd processor) I cannot log into renku when I run cargo run -- login.

This fixes it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try with:

cargo run --features rustls -- login

this would select the "rustls" feature that already configures this dependency. The default feature would link against the openssl system library. Why this is not working anymore, needs to be investigated - strange to me right now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olevski I tried something on this branch. Apparently, if I add the oauth2 crate explicitly (it is pulled in by openidconnect), the login command works on my machine again.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eikek your branch fixes the problem. So can you open a PR for it and I will close this one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR: #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants