Repository navigation
bug: 모집 정원 판정 기준 통일 (fix/recruit-status-capacity) - #437
Merged
Merged
Conversation
하차(WITHDRAWN) 후 신청 행이 남아 정원이 영구 마감되는 버그 수정. 목록·상세·백오피스·SQL 필터 모두 STUDY_PARTICIPANT ACTIVE + CAPACITY_ROLES 로 통일. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…dyListIntegrationTest FK BackofficeStudyListService: programs 맵 미존재 시 NPE → Optional.ofNullable + orElseThrow 로 보호 AdminStudyListIntegrationTest: insertParticipant STUDY_GROUP_ID=0 FK 위반 → STUDY_GROUP_ID=9611L 추가 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
작업 요약
버그 수정: 모집 정원 판정 기준 통일 (fix/recruit-status-capacity)
문제: 모집 중/마감 판정이 화면마다 달랐다. 하차(WITHDRAWN) 후에도 신청 행이 남아 있어 정원이 영구 마감으로 고정되는 버그.
원인: 목록·상세·백오피스·SQL 필터가 각각 다른 기준(신청 건수 vs 명부 인원)으로 정원을 계산.
결정 D4-A: 정원을 차지하는 인원 = 명부 ACTIVE + CAPACITY_ROLES(MEMBER·LEADER). 하차(WITHDRAWN) 시 자리 반납.
변경 사항
체크리스트
Self Review
/self-review실행 또는 수동)console.log/println/ 디버그 코드를 제거했다테스트
./gradlew test/pnpm test)보안 (PUBLIC 레포)
.env파일이 커밋에 포함되지 않았다기타
V{n}__*.sql마이그레이션을 같이 넣었다01-planning/stories/**또는frontend/apps/playground/**/spec.ts를 건드렸다면pnpm --filter playground export-specs --check통과 확인팀 공유
docs/share/에 한 장 (없으면 지운다)docs/incidents/에 한 장 (없으면 지운다)