Skip to content

Remove the stale DEPRECATION suppression - #192

Open
alexander-yevsyukov wants to merge 5 commits into
masterfrom
drop-stale-deprecation-suppression
Open

Remove the stale DEPRECATION suppression#192
alexander-yevsyukov wants to merge 5 commits into
masterfrom
drop-stale-deprecation-suppression

Conversation

@alexander-yevsyukov

Copy link
Copy Markdown
Contributor

Removes a stale @Suppress("DEPRECATION") from the root build.gradle.kts,
where it wrapped the force(...) call in the buildscript resolution strategy.

Why it is stale

git log -S traces the annotation to 6e884740 (Jan 2023), where the forced
list read:

@Suppress("DEPRECATION")
force(
    spine.base,
    spine.validation.java,
    io.spine.internal.dependency.Protobuf.GradlePlugin.lib,
    io.spine.internal.dependency.Kotlin.stdLibJdk8,
)

Every subject of the suppression has since gone:

  • the Spine(project) accessors were replaced by the Base / Reflect objects;
  • Kotlin.stdLibJdk8 — the one entry that is @Deprecated today — was
    dropped from the list entirely.

None of the four coordinates forced today resolves to a deprecated declaration
(Base.lib, Reflect.lib, Validation.java, Protobuf.GradlePlugin.lib), and
ResolutionStrategy.force is not deprecated on Gradle 9.7.1. Left in place, the
annotation would mask a genuine deprecation at this call site later.

Verification

  • Source-level check of all four declarations in the config-distributed
    dependency objects: none is annotated. Validation.kt does carry a deprecated
    member, but it is oldRuntime, which this call does not reference.
  • javap -v on gradle-core-api-9.7.1.jar: ResolutionStrategy carries no
    Deprecated attribute on force, nor does Configuration.resolutionStrategy
    or DomainObjectCollection.all(Action).
  • ./gradlew build dokkaGenerate — BUILD SUCCESSFUL.

Merge order

Takes 2.0.0-SNAPSHOT.423 because .422 is claimed by the in-flight
dependency-refresh PR #191. This PR must merge after #191; merging it first
would leave #191's .422 below the published version and force a re-bump there.

alexander-yevsyukov and others added 3 commits August 30, 2026 17:31
The suppression was added for the old `Spine.base` / `Spine.reflect` members,
renamed to `Base.lib` / `Reflect.lib` in eb663fb. `ResolutionStrategy.force`
is not deprecated on Gradle 9.7.1, and no other `force(` call site in the
repository suppresses anything, so the annotation only stood to mask a genuine
deprecation at this call site later.

Verified with `./gradlew build dokkaGenerate --warning-mode all`: no warning
references the root build script.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
.422 is claimed by the in-flight dependency-refresh PR #191, so this branch
takes .423 and must merge after it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 30, 2026 16:38
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-30T16:40:53.662951Z edf84ba PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a now-unneeded @Suppress("DEPRECATION") around the root buildscript { configurations { all { resolutionStrategy { force(...) }}}} call site, so future genuine deprecations at that location won’t be masked. It also bumps the published snapshot version and regenerates dependency reporting artifacts to match.

Changes:

  • Removed the stale @Suppress("DEPRECATION") annotation from the root build.gradle.kts resolutionStrategy.force(...) block.
  • Bumped versionToPublish from 2.0.0-SNAPSHOT.421 to 2.0.0-SNAPSHOT.423.
  • Updated generated dependency report outputs (docs/dependencies/*) to reflect the new version and generation timestamp.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
build.gradle.kts Drops the stale deprecation suppression at the force(...) call site.
version.gradle.kts Updates versionToPublish to 2.0.0-SNAPSHOT.423.
docs/dependencies/pom.xml Regenerated POM report now reflects version 2.0.0-SNAPSHOT.423.
docs/dependencies/dependencies.md Regenerated dependency/license report reflects the new version and updated generation timestamp.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@alexander-yevsyukov alexander-yevsyukov self-assigned this Aug 30, 2026
@alexander-yevsyukov alexander-yevsyukov moved this to 🏗 In progress in v2.0 Aug 30, 2026
@codecov

codecov Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.76%. Comparing base (ef6a58f) to head (023cd63).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #192   +/-   ##
=========================================
  Coverage     91.76%   91.76%           
  Complexity      840      840           
=========================================
  Files           163      163           
  Lines          3011     3011           
  Branches        375      375           
=========================================
  Hits           2763     2763           
  Misses          116      116           
  Partials        132      132           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexander-yevsyukov alexander-yevsyukov moved this from 🏗 In progress to In Review in v2.0 Aug 30, 2026
alexander-yevsyukov and others added 2 commits August 30, 2026 20:31
…ion-suppression

# Conflicts:
#	docs/dependencies/dependencies.md
#	docs/dependencies/pom.xml
#	version.gradle.kts
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings August 30, 2026 19:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

2 participants