Remove the stale DEPRECATION suppression - #192
Conversation
The suppression was added for the old `Spine.base` / `Spine.reflect` members, renamed to `Base.lib` / `Reflect.lib` in eb663fb. `ResolutionStrategy.force` is not deprecated on Gradle 9.7.1, and no other `force(` call site in the repository suppresses anything, so the annotation only stood to mask a genuine deprecation at this call site later. Verified with `./gradlew build dokkaGenerate --warning-mode all`: no warning references the root build script. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
.422 is claimed by the in-flight dependency-refresh PR #191, so this branch takes .423 and must merge after it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Pull request overview
This PR removes a now-unneeded @Suppress("DEPRECATION") around the root buildscript { configurations { all { resolutionStrategy { force(...) }}}} call site, so future genuine deprecations at that location won’t be masked. It also bumps the published snapshot version and regenerates dependency reporting artifacts to match.
Changes:
- Removed the stale
@Suppress("DEPRECATION")annotation from the rootbuild.gradle.ktsresolutionStrategy.force(...)block. - Bumped
versionToPublishfrom2.0.0-SNAPSHOT.421to2.0.0-SNAPSHOT.423. - Updated generated dependency report outputs (
docs/dependencies/*) to reflect the new version and generation timestamp.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
build.gradle.kts |
Drops the stale deprecation suppression at the force(...) call site. |
version.gradle.kts |
Updates versionToPublish to 2.0.0-SNAPSHOT.423. |
docs/dependencies/pom.xml |
Regenerated POM report now reflects version 2.0.0-SNAPSHOT.423. |
docs/dependencies/dependencies.md |
Regenerated dependency/license report reflects the new version and updated generation timestamp. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #192 +/- ##
=========================================
Coverage 91.76% 91.76%
Complexity 840 840
=========================================
Files 163 163
Lines 3011 3011
Branches 375 375
=========================================
Hits 2763 2763
Misses 116 116
Partials 132 132 🚀 New features to boost your workflow:
|
…ion-suppression # Conflicts: # docs/dependencies/dependencies.md # docs/dependencies/pom.xml # version.gradle.kts
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Removes a stale
@Suppress("DEPRECATION")from the rootbuild.gradle.kts,where it wrapped the
force(...)call in thebuildscriptresolution strategy.Why it is stale
git log -Straces the annotation to6e884740(Jan 2023), where the forcedlist read:
Every subject of the suppression has since gone:
Spine(project)accessors were replaced by theBase/Reflectobjects;Kotlin.stdLibJdk8— the one entry that is@Deprecatedtoday — wasdropped from the list entirely.
None of the four coordinates forced today resolves to a deprecated declaration
(
Base.lib,Reflect.lib,Validation.java,Protobuf.GradlePlugin.lib), andResolutionStrategy.forceis not deprecated on Gradle 9.7.1. Left in place, theannotation would mask a genuine deprecation at this call site later.
Verification
config-distributeddependency objects: none is annotated.
Validation.ktdoes carry a deprecatedmember, but it is
oldRuntime, which this call does not reference.javap -vongradle-core-api-9.7.1.jar:ResolutionStrategycarries noDeprecatedattribute onforce, nor doesConfiguration.resolutionStrategyor
DomainObjectCollection.all(Action)../gradlew build dokkaGenerate— BUILD SUCCESSFUL.Merge order
Takes
2.0.0-SNAPSHOT.423because.422is claimed by the in-flightdependency-refresh PR #191. This PR must merge after #191; merging it first
would leave #191's
.422below the published version and force a re-bump there.