Derive the JUnit platform version from JUnit.version - #758
Merged
Conversation
`JUnit.Platform.version` repeated the JUnit version as a literal, so a JUnit bump had to be applied in two places. The most recent one, to `6.1.3`, happened to be applied to both; nothing enforces that. `JUnit.Jupiter.version` already reads `JUnit.version`, so this only makes `Platform` follow the sibling it sits next to. Safe because JUnit 6 unified the two version lines: `junit-bom:6.1.3` declares `junit-platform-launcher:6.1.3`. Under JUnit 5 they genuinely differed — the platform was `1.x` against Jupiter's `5.x` — so the KDoc now records why the values may be tied together. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
armiol
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
JUnit.Platform.versionheld the JUnit version as its own literal:Every JUnit bump therefore had to be applied twice. The latest bump to
6.1.3was applied to both, but nothing enforced that — the two could drift silently,
and the platform artifacts would then be pinned off the BOM's line.
Fix
Read
JUnit.versioninstead.JUnit.Jupiter.versionalready does exactlythis, so
Platformnow matches the sibling declared a few lines above it.Why this is safe
JUnit 6 unified the platform and Jupiter version lines. Verified directly
against Maven Central:
junit-bom:6.1.3declaresjunit-platform-launcher:6.1.3, and that artifact resolves (HTTP 200).This was not true under JUnit 5, where the platform was
1.xwhileJupiter was
5.x. The KDoc now records that history, so the next reader doesnot have to rediscover why tying the values together is correct now and would
have been a bug before.
No version changes: both sides were already
6.1.3.Verification
./gradlew detekt— BUILD SUCCESSFUL.dependency-audit— APPROVE. It also confirmed there is no Kotlinobject-initialization-order hazard in reading
JUnit.versionfrom thenested
Platformobject, and found no consumer readingJUnit.Platform.versiondirectly.Where this came from
Reported by Copilot on
jdbc-storage#183.
buildSrc/src/main/kotlin/io/spine/dependency/**is config-distributed, sojdbc-storage only carries the overlay — the fix belongs here.
🤖 Generated with Claude Code