-
Notifications
You must be signed in to change notification settings - Fork 0
Assign Claude model tiers to skill wrappers #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alexander-yevsyukov
merged 9 commits into
master
from
claude/optimize-stills-model-usage-6ab197
Jul 17, 2026
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c5591d4
Assign Claude model tiers to skill wrappers
alexander-yevsyukov 75241ca
Address Copilot review on PR #34
alexander-yevsyukov beeffd7
Move bump-version and version-bumped to the haiku tier
alexander-yevsyukov 0c99f4b
Address Codex and Copilot round-2 review on PR #34
alexander-yevsyukov d3acf9b
Clarify that model: inherit applies to agent wrappers only
alexander-yevsyukov 5c9b51c
Address Copilot round-4 review: wrapper frontmatter cleanup
alexander-yevsyukov db35a6b
Align the which-fixer report line with the skill's contract
alexander-yevsyukov e98c1ab
Condition the check-links agent sentinel on the pipeline running
alexander-yevsyukov d8ae9a2
Merge origin/master, reconciling wrapper conventions
alexander-yevsyukov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| --- | ||
| name: check-links | ||
| description: > | ||
| Validates the Hugo documentation site under `docs/` or `site/` for broken | ||
| links — builds the site, serves it locally, runs Lychee with the repo's | ||
| `lychee.toml`, and reports broken URLs grouped by source Markdown page. Use | ||
| when a diff touches `docs/**`, `site/**`, or `lychee.toml`, when CI's | ||
| `Check Links` job fails, or when the user asks to check doc links. Reports | ||
| "not applicable" when no Hugo site exists. Read-only with respect to | ||
| project sources; does not run Gradle builds. | ||
| tools: Read, Grep, Glob, Bash | ||
| model: haiku | ||
| --- | ||
|
|
||
| Follow the `check-links` skill exactly: | ||
|
|
||
| - Skill: `.agents/skills/check-links/SKILL.md` | ||
| - The skill owns the procedure (site detection, binary preflight against the | ||
| CI-pinned versions, `npm ci`, Hugo build and serve on port `1414`, the | ||
| Lychee run, teardown) and the report format (broken URLs grouped by | ||
| source Markdown page). | ||
| - If no Hugo config exists under `docs/` or `site/`, return | ||
| `APPROVE — no Hugo documentation site found under docs/ or site/.` and stop. | ||
| - When the pipeline runs, write the `check-links.ok` sentinel to the | ||
| repository's git directory as the skill's final step — the `pre-pr` gate | ||
| reads it to skip a redundant re-run at the same HEAD. The not-applicable | ||
| early exit above writes no sentinel. | ||
| - Read-only with respect to tracked sources: use `Bash` for the | ||
| build/serve/check pipeline, git-ignored caches, and the sentinel only; | ||
| never modify project files. | ||
| - End with the reviewers' one-line verdict so `pre-pr` can aggregate this | ||
| agent like the other reviewers: `APPROVE` when no broken links are found | ||
| (or the check is not applicable), `REQUEST CHANGES` when Lychee reports | ||
| broken URLs or the pipeline itself fails (preflight, build, or server | ||
| errors). Place the skill's report above the verdict line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| --- | ||
| name: gradle-review | ||
| description: > | ||
| Reviews Gradle-related changes against Spine SDK conventions and the | ||
| upstream Gradle best-practices guides ingested under the skill's | ||
| `practices/`. Scope: `buildSrc/` in the `config` repository, Gradle build | ||
| files in any project, and production code of Gradle plugins exposed by | ||
| Spine SDK tools. Use proactively after any non-trivial change to build | ||
| logic, before opening a PR, or when the user asks for a Gradle review. | ||
| Read-only; does not run builds. | ||
| tools: Read, Grep, Glob, Bash | ||
| model: sonnet | ||
| --- | ||
|
|
||
| Follow the `gradle-review` skill exactly: | ||
|
|
||
| - Skill: `.agents/skills/gradle-review/SKILL.md` | ||
| - The skill owns the scope rules (config-repo `buildSrc/`, Gradle build | ||
| files, plugin production code), the Spine task conventions, the ingested | ||
| `practices/` checks, and the output format (Must fix / Should fix / | ||
| Nits + one-line verdict). | ||
| - Do not duplicate `spine-code-review` (repo-specific safety rules, testing | ||
| policy, version gate), `kotlin-engineer` (general Kotlin language | ||
| standards), or `dependency-audit` (declarations under | ||
| `buildSrc/src/main/kotlin/io/spine/dependency/`) — they review in | ||
| parallel. If such an issue surfaces, note it briefly as a Nit pointing | ||
| at the owning agent. | ||
| - Read-only: use `Read`, `Grep`, `Glob`, and `Bash` solely for `git diff`, | ||
| `git remote -v`, the skill's search recipes, and related read-only | ||
| inspection. Do not run builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| --- | ||
| description: > | ||
| Resolve a Maven artifact's on-disk sources instead of unzipping | ||
| Gradle-cache JARs. | ||
| argument-hint: "<group:artifact[:version] | artifact>" | ||
| allowed-tools: >- | ||
| Read, Grep, Glob, Write, Bash(.agents/scripts/api-discovery/discover:*), | ||
| Bash(.agents/scripts/api-discovery/update-sibling:*), Bash(mkdir:*) | ||
| model: haiku | ||
| --- | ||
|
|
||
| Follow the `api-discovery` skill exactly: | ||
|
|
||
| - Skill: `.agents/skills/api-discovery/SKILL.md` | ||
| - Query: $ARGUMENTS | ||
| - Run `.agents/scripts/api-discovery/discover $ARGUMENTS`; stdout is the | ||
| resolved path, stderr carries warnings the user must see. | ||
| - Exit 10 → run the skill's bootstrap flow (ask the user before creating | ||
| the cache directory). Exit 1 → report the failure verbatim; never fall | ||
| back to `unzip` against Gradle caches. | ||
| - On a `STALE:` warning, offer `update-sibling` per the skill and read its | ||
| stdout token (`pulled` | `up-to-date` | `skipped-branch`) to decide the | ||
| next step. | ||
| - Report the resolved path and any warnings so follow-up work can read the | ||
| sources directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| --- | ||
| description: > | ||
| Check the Hugo documentation site for broken links, mirroring CI's | ||
| Check Links job. | ||
| argument-hint: "[base-ref]" | ||
| allowed-tools: Read, Grep, Glob, Bash | ||
| model: haiku | ||
| --- | ||
|
|
||
| Follow the `check-links` skill exactly: | ||
|
|
||
| - Skill: `.agents/skills/check-links/SKILL.md` | ||
| - Base ref for the scope check: $ARGUMENTS (treat empty as `master`). | ||
| - The skill owns the procedure (site detection, binary preflight against | ||
| the CI-pinned versions, `npm ci`, Hugo build and serve on port `1414`, | ||
| the Lychee run, teardown) and the report format (broken URLs grouped by | ||
| source Markdown page). | ||
| - If no Hugo config exists under `docs/` or `site/`, return | ||
| `APPROVE — no Hugo documentation site found under docs/ or site/.` and | ||
| stop — do not write a `FAIL` sentinel for that case. | ||
| - When the pipeline runs, always tear the Hugo server down (step 8), even | ||
| when Lychee fails, and write the `check-links.ok` sentinel to the | ||
| repository's git directory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| --- | ||
| description: > | ||
| Verify the branch bumped version.gradle.kts above base; recover via | ||
| bump-version. | ||
| argument-hint: "[base-ref]" | ||
| allowed-tools: >- | ||
| Read, Edit, Bash(.agents/skills/version-bumped/scripts/version-bumped.sh:*), | ||
| Bash(git status:*), Bash(git diff:*), Bash(git log:*), Bash(./gradlew:*) | ||
| model: haiku | ||
| --- | ||
|
|
||
| Follow the `version-bumped` skill exactly: | ||
|
|
||
| - Skill: `.agents/skills/version-bumped/SKILL.md` | ||
| - Run the deterministic check | ||
| `.agents/skills/version-bumped/scripts/version-bumped.sh`. If $ARGUMENTS | ||
| names a base ref, run the script with `VERSION_BUMPED_BASE=<ref>`. | ||
| - Exit 0 → report the one-line confirmation and stop. | ||
| - Exit 2 → configuration error; surface the script's stderr and stop. | ||
| Do not bump. | ||
| - Exit 1 → run the `bump-version` skill to recover (it owns the policy), | ||
| then re-run the check once to confirm. Do not loop. | ||
| - Recovery may commit the bump — that is the `bump-version` skill's | ||
| documented policy; the repo's permission settings still gate `git commit`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| --- | ||
| description: > | ||
| Fix restrictive "which" clauses to "that" in comments and docs. | ||
| allowed-tools: >- | ||
| Read, Edit, Write, Grep, Glob, Bash(git diff:*), Bash(git ls-files:*), | ||
| Bash(git status:*), Bash(cmp:*) | ||
| model: sonnet | ||
| --- | ||
|
|
||
| Follow the `which-fixer` skill exactly: | ||
|
|
||
| - Skill: `.agents/skills/which-fixer/SKILL.md` | ||
| - Mode is automatic: bulk when `.agents/memory/which-fixer-applied.md` is | ||
| absent, incremental otherwise. Do not ask which mode to use. | ||
| - Scope: project-owned files only, per the skill's submodule and | ||
| config-distributed skip rules. | ||
| - Honor every guard in the skill (comma, parenthesis/dash, preposition, | ||
| interrogative, sentence-initial, hyphenated identifier, fixed phrases). | ||
| When uncertain, leave the occurrence unchanged and record it in | ||
| `Skipped[]` — a missed case beats a wrong fix. | ||
| - Never touch code: string literals, identifiers, fenced or indented code | ||
| blocks, inline code spans, or snippets embedded in doc comments. | ||
| - Report per the skill: Mode (bulk | incremental), FilesScanned, | ||
| FilesChanged, Replacements[] (file, line, before → after), Skipped[] | ||
| (file, line, reason). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.