Repository navigation
Fix: grid convolution select_peaks - #4863
Merged
alejoe91 merged 2 commits intoOct 14, 2026
Merged
Conversation
alejoe91
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another bug in postprocessing (spike locations) which we didn't catch with tests.
The issue is that in #4809 we introduced the possibility to compute locations from
spikes(nochannel_index), so we added a way to passchannel_index_arrayexternally. When computing spike locations with grid convolution, we have to slice thechannel_index_arrayaccording to the peak selection. This was not caught by tests since the postprocessing dataset has 163 spikes, and default peak selection is 5000!Extended tests to select 100 peaks for grid convolution.