Repository navigation
Build one probe per electrode group in NwbRecordingExtractor - #4820
Merged
alejoe91 merged 1 commit intoOct 7, 2026
Merged
Conversation
h-mayorquin
added
bug
Member
|
super! |
samuelgarcia
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3999.
NwbRecordingExtractorbuilds a single probe from therel_xandrel_yof every channel in the ElectricalSeries. The NWB schema defines those coordinates relative to the electrode group, so they only need to be unique within a group. When one ElectricalSeries holds several probes of the same type, each one its own electrode group (as in the Frank lab files from the issue), the channels of different probes share positions and loading the recording fails with "Contact positions must be unique within a probe". I now build one probe per electrode group and attach them withcheck_overlap=False, since overlapping groups are valid NWB. Users who want one recording per probe can callrecording.split_by("group")after loading.