Skip to content

Enable case omission on get_unit_spike_train_in_seconds #4811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alejoe91 merged 2 commits into from
Oct 2, 2026
Merged

Enable case omission on get_unit_spike_train_in_seconds #4811

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eebf9b4
Pass use_cache through get_unit_spike_train_in_seconds
h-mayorquin Oct 2, 2026
8c9380f
Merge branch 'main' into forward_use_cache_to_spike_train_in_seconds
h-mayorquin Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/spikeinterface/core/basesorting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ def get_unit_spike_train(
segment_index=segment_index,
start_time=start_time,
end_time=end_time,
use_cache=use_cache,
)

segment_index = self._check_segment_index(segment_index)
Expand Down Expand Up @@ -237,6 +238,7 @@ def get_unit_spike_train_in_seconds(
segment_index: int | None = None,
start_time: float | None = None,
end_time: float | None = None,
use_cache: bool = True,
) -> np.ndarray:
"""
Get spike train for a unit in seconds.
Expand All @@ -261,6 +263,9 @@ def get_unit_spike_train_in_seconds(
The start time in seconds for spike train extraction
end_time : float or None, default: None
The end time in seconds for spike train extraction
use_cache : bool, default: True
Passed to `get_unit_spike_train` when the times are computed from frames.
Ignored when the segment returns native times.

Returns
-------
Expand All @@ -283,7 +288,7 @@ def get_unit_spike_train_in_seconds(
start_frame=start_frame,
end_frame=end_frame,
return_times=False,
use_cache=True,
use_cache=use_cache,
)

spike_times = self.sample_index_to_time(spike_frames, segment_index=segment_index)
Expand Down Expand Up @@ -322,7 +327,7 @@ def get_unit_spike_train_in_seconds(
start_frame=start_frame,
end_frame=end_frame,
return_times=False,
use_cache=True,
use_cache=use_cache,
)

t_start = segment._t_start if segment._t_start is not None else 0
Expand Down
Loading