SONARJAVA-6854 Externalize ruling test project definitions to JSON

[romainbrenguier]

Summary

This change externalizes the hardcoded project name-to-path mappings from JavaRulingTest into a JSON resource file.

Benefits

• Single source of truth: Project definitions are now in one place
• External tool support: External tools can discover available projects by reading the JSON file
• Type safety: RulingProject record provides compile-time type checking
• Centralized assertions: requireProject() method combines lookup with assertion

Changes

• Added ruling-projects.json with all 12 project configurations
• Added RulingProject record with Gson annotations for JSON serialization
• Added ProjectConfigLoader utility with findByProjectName() and requireProject() methods
• Updated JavaRulingTest to use the new loader
• Added unit tests for the new loader classes

[hashicorp-vault-sonar-prod]

SONARJAVA-6854

✅ All code review findings resolved.

_{Configure merge blocking}

[gitar-bot]

Code Review ✅ Approved 2 resolved / 2 findings

Externalizes ruling test project definitions to a JSON configuration file and introduces the RulingProject record for improved type safety. Addressed the wrong pom path resolution and outdated javadoc during the review.

✅ 2 resolved

✅ Bug: sonarqube_server now resolves the wrong pom path, breaking the test

📄 its/ruling/src/test/java/org/sonar/java/it/JavaRulingTest.java:383-386 📄 its/ruling/src/test/java/org/sonar/java/it/JavaRulingTest.java:425-436 📄 its/ruling/src/test/resources/ruling-projects.json:50-55
sonarqube_server previously called the 3-arg test_project("org.sonarsource.sonarqube:sonar-server", "sonarqube-6.5/server", "sonar-server"), producing pom location ../sources/sonarqube-6.5/server/sonar-server/pom.xml. The new executeMavenBuild only calls the 2-arg test_project(projectKey, projectName), which resolves ../sources/sonar-server/pom.xml — a path that does not exist in the its/sources submodule — so the Maven build fails and the only-sonarqube-project CI job (build.yml matrix) fails with "Build failure for project: sonar-server". Note also that path in the JSON is inconsistent between entries (a parent prefix for sonar-server, the full source directory everywhere else, and used as "../sources/" + path in jboss_ejb3_tutorial), and executeMavenBuild ignores path entirely; make path uniformly the full directory under ../sources and have executeMavenBuild use it.

✅ Quality: loadProjects() javadoc contradicts the exceptions it actually throws

📄 its/ruling/src/test/java/org/sonar/java/it/ProjectConfigLoader.java:46-60
The javadoc states @throws IllegalStateException if the resource cannot be found or parsed, but a missing resource throws NullPointerException from Objects.requireNonNull and a malformed JSON file throws Gson's JsonSyntaxException; only the (practically unreachable) IOException from close() is wrapped. Wrap both cases in IllegalStateException so failures surface with the documented type and message.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube