SONARJAVA-6304: Implement S9366: avoid unsupported ChronoUnit values with Instant

[nathsou]

Summary

• Implement S9366 as a semantic SonarJava check for unsupported ChronoUnit constants used with Instant.
• Cover all supported and unsupported units, static imports, custom-unit boundaries, and missing semantics.
• Generate rule metadata and add S9366 to Sonar way.

Links

• Jira: https://sonarsource.atlassian.net/browse/SONARJAVA-6304
• RSPEC PR: https://github.com/SonarSource/rspec/pull/7967

AI disclosure

• LLM model used for implementation: gpt-5.6-sol

[hashicorp-vault-sonar-prod]

SONARJAVA-6304

[gitar-bot]

💡 Quality: Unreachable guard in onMethodInvocationFound

onMethodInvocationFound is only invoked after MethodMatchers resolved the invocation against java.time.Instant, which requires semantics; with withoutSemantic() the method symbol is unknown and the callback never fires, so context.getSemanticModel() == null can never be true here. Likewise both matchers declare exactly two parameters, so mit.arguments().size() < 2 is never true. The two conditions are unreachable branches (and test_without_semantic does not actually exercise them); dropping them simplifies the check and avoids uncovered branches.

Remove the unreachable semantic/arity guard (the matchers already guarantee both).:

@Override
protected void onMethodInvocationFound(MethodInvocationTree mit) {
  ExpressionTree argument = mit.arguments().get(1);
  Symbol symbol = referencedSymbol(ExpressionUtils.skipParentheses(argument));
  if (isChronoUnitConstant(symbol) && UNSUPPORTED_UNITS.contains(symbol.name())) {
    reportIssue(argument, String.format(""%s" is unsupported by Instant and causes an UnsupportedTemporalTypeException.", symbol.name()));
  }
}

• Apply fix

_{Check the box to apply the fix or reply for a change | Was this helpful? React with 👍 / 👎}

[gitar-bot]

Code Review 👍 Approved with suggestions 0 resolved / 1 findings

Implements rule S9366 to detect unsupported ChronoUnit values with Instant, complete with thorough test coverage and metadata. Consider removing the unreachable guard in onMethodInvocationFound.

💡 Quality: Unreachable guard in onMethodInvocationFound

📄 java-checks/src/main/java/org/sonar/java/checks/UnsupportedChronoUnitWithInstantCheck.java:74-78 📄 java-checks/src/test/java/org/sonar/java/checks/UnsupportedChronoUnitWithInstantCheckTest.java:36-43

onMethodInvocationFound is only invoked after MethodMatchers resolved the invocation against java.time.Instant, which requires semantics; with withoutSemantic() the method symbol is unknown and the callback never fires, so context.getSemanticModel() == null can never be true here. Likewise both matchers declare exactly two parameters, so mit.arguments().size() < 2 is never true. The two conditions are unreachable branches (and test_without_semantic does not actually exercise them); dropping them simplifies the check and avoids uncovered branches.

Remove the unreachable semantic/arity guard (the matchers already guarantee both).

@Override
protected void onMethodInvocationFound(MethodInvocationTree mit) {
  ExpressionTree argument = mit.arguments().get(1);
  Symbol symbol = referencedSymbol(ExpressionUtils.skipParentheses(argument));
  if (isChronoUnitConstant(symbol) && UNSUPPORTED_UNITS.contains(symbol.name())) {
    reportIssue(argument, String.format(""%s" is unsupported by Instant and causes an UnsupportedTemporalTypeException.", symbol.name()));
  }
}

🤖 Prompt for agents

Code Review: Implements rule S9366 to detect unsupported ChronoUnit values with Instant, complete with thorough test coverage and metadata. Consider removing the unreachable guard in onMethodInvocationFound.

1. 💡 Quality: Unreachable guard in onMethodInvocationFound
   Files: java-checks/src/main/java/org/sonar/java/checks/UnsupportedChronoUnitWithInstantCheck.java:74-78, java-checks/src/test/java/org/sonar/java/checks/UnsupportedChronoUnitWithInstantCheckTest.java:36-43

   `onMethodInvocationFound` is only invoked after `MethodMatchers` resolved the invocation against `java.time.Instant`, which requires semantics; with `withoutSemantic()` the method symbol is unknown and the callback never fires, so `context.getSemanticModel() == null` can never be true here. Likewise both matchers declare exactly two parameters, so `mit.arguments().size() < 2` is never true. The two conditions are unreachable branches (and `test_without_semantic` does not actually exercise them); dropping them simplifies the check and avoids uncovered branches.

   Fix (Remove the unreachable semantic/arity guard (the matchers already guarantee both).):
   @Override
   protected void onMethodInvocationFound(MethodInvocationTree mit) {
     ExpressionTree argument = mit.arguments().get(1);
     Symbol symbol = referencedSymbol(ExpressionUtils.skipParentheses(argument));
     if (isChronoUnitConstant(symbol) && UNSUPPORTED_UNITS.contains(symbol.name())) {
       reportIssue(argument, String.format(""%s" is unsupported by Instant and causes an UnsupportedTemporalTypeException.", symbol.name()));
     }
   }

Implementation Status ✅ 4 of 4 objectives covered

✅ SONARJAVA-6304 - 4 of 4 objectives covered

This PR implements the S9366 rule for unsupported ChronoUnit values with Instant, covering all specified objectives including custom unit exclusion, variable propagation restriction, rule creation, and semantic ChronoUnit verification.

✅ 4 covered here

• ✅ Exclude custom TemporalUnit implementations from reporting
• ✅ Exclude value propagation through variables in the initial implementation
• ✅ Create SonarJava rule S9366 to report known unsupported ChronoUnit constants passed to Instant.plus, Instant.minus, or Instant.until
• ✅ Report direct enum constants, including statically imported constants, only when semantic resolution confirms the symbol belongs to java.time.temporal.ChronoUnit

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
91.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube