SONARJAVA-6823: Implemented rule S909 "continue" should not be used by romainbrenguier · Pull Request #5989 · SonarSource/sonar-java

romainbrenguier · 2026-08-21T14:48:12Z

Summary

Implemented rule S909 that flags every use of the continue statement inside loops (for, for-each, while, do-while), whether labeled or unlabeled
The rule is a CODE_SMELL with MEDIUM impact on MAINTAINABILITY — loops should use inverted conditional logic instead of continue
Simple IssuableSubscriptionVisitor subscribing to CONTINUE_STATEMENT

Test plan

Unit test ContinueInLoopCheckTest passes
CI passes (ruling tests may need baseline updates)
Verify no false positives on ruling projects

🤖 Generated with Claude Code

…in loops Detect every use of the continue statement inside loops (for, for-each, while, do-while), whether labeled or unlabeled. The rule flags continue as a code smell that reduces readability — loops should use inverted conditional logic instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

hashicorp-vault-sonar-prod · 2026-08-21T14:48:25Z

SONARJAVA-6823

github-actions · 2026-08-21T15:03:32Z

❌ Ruling needs updating. A fix PR has been created: #5992

Please review and merge it into your branch.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

github-actions · 2026-08-21T15:16:42Z

Ruling Diff Summary

Detected changes in 5 rule files: 0 issues removed, 383 issues added.

S909 (java) on commons-beanutils - 0 issues removed, 5 issues added - new ruling file

Added src/main/java/org/apache/commons/beanutils2/BeanUtilsBean.java (line 276)

       271 |             final PropertyDescriptor[] origDescriptors =
       272 |                 getPropertyUtils().getPropertyDescriptors(orig);
       273 |             for (final PropertyDescriptor origDescriptor : origDescriptors) {
       274 |                 final String name = origDescriptor.getName();
       275 |                 if ("class".equals(name)) {
>>>    276 |                     continue; // No point in trying to set an object's class
       277 |                 }
       278 |                 if (getPropertyUtils().isReadable(orig, name) &&
       279 |                     getPropertyUtils().isWriteable(dest, name)) {
       280 |                     try {
       281 |                         final Object value =

Added src/main/java/org/apache/commons/beanutils2/BeanUtilsBean.java (line 819)

       814 |         // Loop through the property name/value pairs to be set
       815 |         for(final Map.Entry<String, ? extends Object> entry : properties.entrySet()) {
       816 |             // Identify the property name and value(s) to be assigned
       817 |             final String name = entry.getKey();
       818 |             if (name == null) {
>>>    819 |                 continue;
       820 |             }
       821 | 
       822 |             // Perform the assignment for this property
       823 |             setProperty(bean, name, entry.getValue());
       824 |

Added src/main/java/org/apache/commons/beanutils2/MappedPropertyDescriptor.java (line 346)

       341 |         // So we start with the given class and walk up the superclass chain.
       342 |         for (Class<?> clazz = initial; clazz != null; clazz = clazz.getSuperclass()) {
       343 |             final Method[] methods = clazz.getDeclaredMethods();
       344 |             for (final Method method : methods) {
       345 |                 if (method == null) {
>>>    346 |                     continue;
       347 |                 }
       348 |                 // skip static methods.
       349 |                 final int mods = method.getModifiers();
       350 |                 if (!Modifier.isPublic(mods) ||
       351 |                     Modifier.isStatic(mods)) {

Added src/main/java/org/apache/commons/beanutils2/MappedPropertyDescriptor.java (line 352)

       347 |                 }
       348 |                 // skip static methods.
       349 |                 final int mods = method.getModifiers();
       350 |                 if (!Modifier.isPublic(mods) ||
       351 |                     Modifier.isStatic(mods)) {
>>>    352 |                     continue;
       353 |                 }
       354 |                 if (method.getName().equals(methodName) &&
       355 |                         method.getParameterTypes().length == parameterCount) {
       356 |                     return method;
       357 |                 }

Added src/main/java/org/apache/commons/beanutils2/MethodUtils.java (line 880)

       875 |             final Class<?>[] interfaces = clazz.getInterfaces();
       876 |             for (int i = 0; i < interfaces.length; i++) {
       877 | 
       878 |                 // Is this interface public?
       879 |                 if (!Modifier.isPublic(interfaces[i].getModifiers())) {
>>>    880 |                     continue;
       881 |                 }
       882 | 
       883 |                 // Does the method exist on this interface?
       884 |                 try {
       885 |                     method = interfaces[i].getDeclaredMethod(methodName,

S909 (java) on eclipse-jetty - 0 issues removed, 221 issues added - new ruling file

Added jetty-http/src/main/java/org/eclipse/jetty/http/CookieCutter.java (line 88)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/CookieCutter.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/CookieCutter.java (line 102)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/CookieCutter.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/CookieCutter.java (line 109)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/CookieCutter.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/GZIPContentDecoder.java (line 196)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/GZIPContentDecoder.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/GZIPContentDecoder.java (line 252)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/GZIPContentDecoder.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/HttpCompliance.java (line 168)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/HttpCompliance.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/HttpFields.java (line 1325)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/HttpFields.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/HttpGenerator.java (line 846)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/HttpGenerator.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/HttpParser.java (line 872)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/HttpParser.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/HttpParser.java (line 894)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/HttpParser.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/HttpURI.java (line 841)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/HttpURI.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/HttpURI.java (line 888)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/HttpURI.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/HttpURI.java (line 923)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/HttpURI.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/MimeTypes.java (line 433)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/MimeTypes.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/MimeTypes.java (line 439)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/MimeTypes.java)

S909 (java) on eclipse-jetty-similar-to-main - 0 issues removed, 113 issues added - new ruling file

Added jetty-http/src/main/java/org/eclipse/jetty/http/CookieCutter.java (line 88)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/CookieCutter.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/CookieCutter.java (line 102)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/CookieCutter.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/CookieCutter.java (line 109)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/CookieCutter.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/GZIPContentDecoder.java (line 196)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/GZIPContentDecoder.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/GZIPContentDecoder.java (line 252)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/GZIPContentDecoder.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/HttpCompliance.java (line 168)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/HttpCompliance.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/HttpFields.java (line 1325)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/HttpFields.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/HttpGenerator.java (line 846)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/HttpGenerator.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/HttpParser.java (line 872)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/HttpParser.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/HttpParser.java (line 894)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/HttpParser.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/HttpURI.java (line 841)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/HttpURI.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/HttpURI.java (line 888)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/HttpURI.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/HttpURI.java (line 923)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/HttpURI.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/MimeTypes.java (line 433)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/MimeTypes.java)

Added jetty-http/src/main/java/org/eclipse/jetty/http/MimeTypes.java (line 439)

(source file not found at this revision: jetty-http/src/main/java/org/eclipse/jetty/http/MimeTypes.java)

S909 (java) on guava - 0 issues removed, 36 issues added - new ruling file

Added src/com/google/common/base/Ascii.java (line 647)

       642 |     }
       643 |     for (int i = 0; i < length; i++) {
       644 |       char c1 = s1.charAt(i);
       645 |       char c2 = s2.charAt(i);
       646 |       if (c1 == c2) {
>>>    647 |         continue;
       648 |       }
       649 |       int alphaIndex = getAlphaIndex(c1);
       650 |       // This was also benchmarked using '&' to avoid branching (but always evaluate the rhs),
       651 |       // however this showed no obvious improvement.
       652 |       if (alphaIndex < 26 && alphaIndex == getAlphaIndex(c2)) {

Added src/com/google/common/base/Ascii.java (line 653)

       648 |       }
       649 |       int alphaIndex = getAlphaIndex(c1);
       650 |       // This was also benchmarked using '&' to avoid branching (but always evaluate the rhs),
       651 |       // however this showed no obvious improvement.
       652 |       if (alphaIndex < 26 && alphaIndex == getAlphaIndex(c2)) {
>>>    653 |         continue;
       654 |       }
       655 |       return false;
       656 |     }
       657 |     return true;
       658 |   }

Added src/com/google/common/base/Splitter.java (line 191)

       186 | 
       187 |                 positions:
       188 |                 for (int p = start, last = toSplit.length() - separatorLength; p <= last; p++) {
       189 |                   for (int i = 0; i < separatorLength; i++) {
       190 |                     if (toSplit.charAt(i + p) != separator.charAt(i)) {
>>>    191 |                       continue positions;
       192 |                     }
       193 |                   }
       194 |                   return p;
       195 |                 }
       196 |                 return -1;

Added src/com/google/common/base/Splitter.java (line 606)

       601 |            */
       602 |           offset++;
       603 |           if (offset >= toSplit.length()) {
       604 |             offset = -1;
       605 |           }
>>>    606 |           continue;
       607 |         }
       608 | 
       609 |         while (start < end && trimmer.matches(toSplit.charAt(start))) {
       610 |           start++;
       611 |         }

Added src/com/google/common/base/Splitter.java (line 619)

       614 |         }
       615 | 
       616 |         if (omitEmptyStrings && start == end) {
       617 |           // Don't include the (unused) separator in next split string.
       618 |           nextStart = offset;
>>>    619 |           continue;
       620 |         }
       621 | 
       622 |         if (limit == 1) {
       623 |           // The limit has been reached, return the rest of the string as the
       624 |           // final item.  This is tested after empty string removal so that

Added src/com/google/common/cache/LocalCache.java (line 2713)

      2708 | 
      2709 |     @Nullable
      2710 |     ReferenceEntry<K, V> getEntry(Object key, int hash) {
      2711 |       for (ReferenceEntry<K, V> e = getFirst(hash); e != null; e = e.getNext()) {
      2712 |         if (e.getHash() != hash) {
>>>   2713 |           continue;
      2714 |         }
      2715 | 
      2716 |         K entryKey = e.getKey();
      2717 |         if (entryKey == null) {
      2718 |           tryDrainReferenceQueues();

Added src/com/google/common/cache/LocalCache.java (line 2719)

      2714 |         }
      2715 | 
      2716 |         K entryKey = e.getKey();
      2717 |         if (entryKey == null) {
      2718 |           tryDrainReferenceQueues();
>>>   2719 |           continue;
      2720 |         }
      2721 | 
      2722 |         if (map.keyEquivalence.equivalent(key, entryKey)) {
      2723 |           return e;
      2724 |         }

Added src/com/google/common/cache/LocalCache.java (line 2819)

      2814 |           int length = table.length();
      2815 |           for (int i = 0; i < length; ++i) {
      2816 |             for (ReferenceEntry<K, V> e = table.get(i); e != null; e = e.getNext()) {
      2817 |               V entryValue = getLiveValue(e, now);
      2818 |               if (entryValue == null) {
>>>   2819 |                 continue;
      2820 |               }
      2821 |               if (map.valueEquivalence.equivalent(value, entryValue)) {
      2822 |                 return true;
      2823 |               }
      2824 |             }

Added src/com/google/common/cache/Striped64.java (line 224)

       219 |                             } finally {
       220 |                                 busy = 0;
       221 |                             }
       222 |                             if (created)
       223 |                                 break;
>>>    224 |                             continue;           // Slot is now non-empty
       225 |                         }
       226 |                     }
       227 |                     collide = false;
       228 |                 }
       229 |                 else if (!wasUncontended)       // CAS already known to fail

Added src/com/google/common/cache/Striped64.java (line 249)

       244 |                         }
       245 |                     } finally {
       246 |                         busy = 0;
       247 |                     }
       248 |                     collide = false;
>>>    249 |                     continue;                   // Retry with expanded table
       250 |                 }
       251 |                 h ^= h << 13;                   // Rehash
       252 |                 h ^= h >>> 17;
       253 |                 h ^= h << 5;
       254 |                 hc[0] = h;                      // Record index for next time

Added src/com/google/common/collect/Collections2.java (line 644)

       639 | 
       640 |       while (true) {
       641 |         int q = c[j] + o[j];
       642 |         if (q < 0) {
       643 |           switchDirection();
>>>    644 |           continue;
       645 |         }
       646 |         if (q == j + 1) {
       647 |           if (j == 0) {
       648 |             break;
       649 |           }

Added src/com/google/common/collect/Collections2.java (line 652)

       647 |           if (j == 0) {
       648 |             break;
       649 |           }
       650 |           s++;
       651 |           switchDirection();
>>>    652 |           continue;
       653 |         }
       654 | 
       655 |         Collections.swap(list, j - c[j] + s, j - q + s);
       656 |         c[j] = q;
       657 |         break;

Added src/com/google/common/collect/ComputingConcurrentHashMap.java (line 165)

       160 |           if (value != null) {
       161 |             recordRead(e);
       162 |             return value;
       163 |           }
       164 |           // else computing thread will clearValue
>>>    165 |           continue outer;
       166 |         }
       167 |       } finally {
       168 |         postReadCleanup();
       169 |       }
       170 |     }

Added src/com/google/common/collect/MapMakerInternalMap.java (line 2406)

      2401 | 
      2402 |     ReferenceEntry<K, V> getEntry(Object key, int hash) {
      2403 |       if (count != 0) { // read-volatile
      2404 |         for (ReferenceEntry<K, V> e = getFirst(hash); e != null; e = e.getNext()) {
      2405 |           if (e.getHash() != hash) {
>>>   2406 |             continue;
      2407 |           }
      2408 | 
      2409 |           K entryKey = e.getKey();
      2410 |           if (entryKey == null) {
      2411 |             tryDrainReferenceQueues();

Added src/com/google/common/collect/MapMakerInternalMap.java (line 2412)

      2407 |           }
      2408 | 
      2409 |           K entryKey = e.getKey();
      2410 |           if (entryKey == null) {
      2411 |             tryDrainReferenceQueues();
>>>   2412 |             continue;
      2413 |           }
      2414 | 
      2415 |           if (map.keyEquivalence.equivalent(key, entryKey)) {
      2416 |             return e;
      2417 |           }

S909 (java) on sonar-server - 0 issues removed, 8 issues added - new ruling file

Added src/main/java/org/sonar/server/computation/task/projectanalysis/filemove/FileMoveDetectionStep.java (line 208)

(source file not found at this revision: src/main/java/org/sonar/server/computation/task/projectanalysis/filemove/FileMoveDetectionStep.java)

Added src/main/java/org/sonar/server/computation/task/projectanalysis/issue/TrackerRawInputFactory.java (line 103)

(source file not found at this revision: src/main/java/org/sonar/server/computation/task/projectanalysis/issue/TrackerRawInputFactory.java)

Added src/main/java/org/sonar/server/computation/task/projectanalysis/step/PersistMeasuresStep.java (line 112)

(source file not found at this revision: src/main/java/org/sonar/server/computation/task/projectanalysis/step/PersistMeasuresStep.java)

Added src/main/java/org/sonar/server/computation/task/projectanalysis/step/QualityGateMeasuresStep.java (line 179)

(source file not found at this revision: src/main/java/org/sonar/server/computation/task/projectanalysis/step/QualityGateMeasuresStep.java)

Added src/main/java/org/sonar/server/rule/RegisterRules.java (line 117)

(source file not found at this revision: src/main/java/org/sonar/server/rule/RegisterRules.java)

Added src/main/java/org/sonar/server/rule/RegisterRules.java (line 354)

(source file not found at this revision: src/main/java/org/sonar/server/rule/RegisterRules.java)

Added src/main/java/org/sonar/server/rule/RegisterRules.java (line 363)

(source file not found at this revision: src/main/java/org/sonar/server/rule/RegisterRules.java)

Added src/main/java/org/sonar/server/user/UserUpdater.java (line 344)

(source file not found at this revision: src/main/java/org/sonar/server/user/UserUpdater.java)

github-actions · 2026-08-21T15:33:38Z

❌ Ruling needs updating. A fix PR has been created: #5994

Please review and merge it into your branch.

Prompt: Add a test withoutSemantic for the new rule Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

github-actions · 2026-08-24T09:16:28Z

❌ Ruling needs updating. A fix PR has been created: #5994

Please review and merge it into your branch.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

nathsou

This is a duplicate of S909 which is already implemented in C, JS and PLSQL.
Please reuse this rule id instead of S9356.

Apart from that, LGTM!

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

github-actions · 2026-08-25T10:08:37Z

❌ Ruling needs updating. A fix PR has been created: #6030

Please review and merge it into your branch.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

github-actions · 2026-08-25T10:26:00Z

❌ Ruling needs updating. A fix PR has been created: #6032

Please review and merge it into your branch.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…r-to-main The ruling expectation file was left behind when the rule key was renamed from S9356 to S909, causing the Ruling QA CI check to fail. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

gitar-bot · 2026-08-25T11:21:12Z

Code Review ✅ Approved 2 resolved / 2 findings

Implements rule S9356 to flag 'continue' statements inside loops, addressing the duplicate sentence in the rule description and stale ruling expectations.

✅ 2 resolved

✅ Quality: Duplicated sentence in S9356.html rule description

📄 sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S9356.html:3 📄 sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S9356.html:20
The sentence stating that in Java this refers to the continue statement appears twice: line 3 ("In Java, this specifically refers to the continue statement.") and line 20 ("In Java, this refers to the continue statement."). The second occurrence is redundant and should be removed for cleaner documentation.

✅ Bug: Stale java-S9356.json ruling expectation left after rule key rename

📄 its/ruling/src/test/resources/eclipse-jetty-similar-to-main/java-S9356.json 📄 its/ruling/src/test/resources/eclipse-jetty-similar-to-main/java-S909.json:1-15 📄 sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S909.json:1-15
Commit 8078eea renamed the S9356 ruling dumps to S909 for commons-beanutils, eclipse-jetty, guava and sonar-server but missed its/ruling/src/test/resources/eclipse-jetty-similar-to-main/java-S9356.json, and the latest ruling-bot commit then added java-S909.json alongside it. Because sonar.lits.dump.old is set to src/test/resources/<projectName> (JavaRulingTest:474, with the whole resources dir used when SUBSET_OF_ENABLED_RULES is empty), LITS will compare the 199 expected java:S9356 issues against zero actual issues for that (now non-existent) rule key and write differences, so assertNoDifferences("eclipse-jetty-similar-to-main") in eclipse_jetty_incremental fails. The stale file is also content-wise obsolete: it contains issues in src/test/java files, which the new S909 metadata ("scope": "Main") no longer reports. Delete its/ruling/src/test/resources/eclipse-jetty-similar-to-main/java-S9356.json.

Implementation Status ✅ 1 of 1 objectives covered

✅ SONARJAVA-6823 - 1 of 1 objectives covered

This PR covers the implementation of rule S909 'continue' should not be used in loops.

✅ 1 covered here

✅ Implement rule S909 'continue' should not be used in loops

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

`Auto-apply`	`Compact`
`gitar auto-apply:on`	`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Gitar}

sonarqube-next · 2026-08-25T11:29:43Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

gitar-bot Bot reviewed Aug 21, 2026

View reviewed changes

Comment thread sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S9356.html Outdated

This comment has been minimized.

Sign in to view

github-actions Bot mentioned this pull request Aug 21, 2026

Update ruling results for PR #5989 #5992

Merged

romainbrenguier commented Aug 21, 2026

View reviewed changes

Comment thread java-checks/src/test/java/org/sonar/java/checks/ContinueInLoopCheckTest.java

Update ruling results for PR #5989 (#5992)

3c56e83

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

github-actions Bot mentioned this pull request Aug 21, 2026

Update ruling results for PR #5989 #5994

Merged

SONARJAVA-6823: Add withoutSemantic test for S9356

897e13b

Prompt: Add a test withoutSemantic for the new rule Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Update ruling results for PR #5989 (#5994)

3e4cce6

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

romainbrenguier requested a review from nathsou August 24, 2026 11:26

romainbrenguier marked this pull request as ready for review August 24, 2026 11:26

nathsou requested changes Aug 24, 2026

View reviewed changes

SONARJAVA-6823: Use S909 rule key instead of S9356

8078eea

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

romainbrenguier changed the title ~~SONARJAVA-6823: Implemented rule S9356 "continue" should not be used in loops~~ SONARJAVA-6823: Implemented rule S909 "continue" should not be used Aug 25, 2026

github-actions Bot mentioned this pull request Aug 25, 2026

Update ruling results for PR #5989 #6030

Merged

Update ruling results for PR #5989 (#6030)

f7f3eae

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

github-actions Bot mentioned this pull request Aug 25, 2026

Update ruling results for PR #5989 #6032

Merged

Update ruling results for PR #5989 (#6032)

453282a

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

gitar-bot Bot reviewed Aug 25, 2026

View reviewed changes

Comment thread its/ruling/src/test/resources/eclipse-jetty-similar-to-main/java-S909.json

SONARJAVA-6823: Remove stale java-S9356.json for eclipse-jetty-simila…

eda455c

…r-to-main The ruling expectation file was left behind when the rule key was renamed from S9356 to S909, causing the Ruling QA CI check to fail. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

romainbrenguier requested a review from nathsou August 25, 2026 11:21

nathsou approved these changes Aug 25, 2026

View reviewed changes

romainbrenguier merged commit 57b0cf3 into master Aug 26, 2026
19 checks passed

romainbrenguier deleted the romain/new-rule-s9356-sonarjava-6823 branch August 26, 2026 09:32

Navigation Menu

Uh oh!

SONARJAVA-6823: Implemented rule S909 "continue" should not be used - #5989

SONARJAVA-6823: Implemented rule S909 "continue" should not be used#5989
romainbrenguier merged 8 commits into
masterfrom
romain/new-rule-s9356-sonarjava-6823

romainbrenguier commented Aug 21, 2026 •

edited by nathsou

Loading

Uh oh!

hashicorp-vault-sonar-prod Bot commented Aug 21, 2026 •

edited by atlassian Bot

Loading

Uh oh!

Uh oh!

This comment has been minimized.

github-actions Bot commented Aug 21, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 21, 2026

Uh oh!

github-actions Bot commented Aug 24, 2026

Uh oh!

nathsou left a comment •

edited

Loading

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

Uh oh!

gitar-bot Bot commented Aug 25, 2026 •

edited

Loading

Uh oh!

sonarqube-next Bot commented Aug 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

romainbrenguier commented Aug 21, 2026 • edited by nathsou Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

hashicorp-vault-sonar-prod Bot commented Aug 21, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

github-actions Bot commented Aug 21, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Ruling Diff Summary

Uh oh!

github-actions Bot commented Aug 21, 2026

Uh oh!

github-actions Bot commented Aug 24, 2026

Uh oh!

nathsou left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

Uh oh!

gitar-bot Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqube-next Bot commented Aug 25, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

romainbrenguier commented Aug 21, 2026 •

edited by nathsou

Loading

hashicorp-vault-sonar-prod Bot commented Aug 21, 2026 •

edited by atlassian Bot

Loading

github-actions Bot commented Aug 21, 2026 •

edited

Loading

nathsou left a comment •

edited

Loading

gitar-bot Bot commented Aug 25, 2026 •

edited

Loading