Skip to content

SONARJAVA-6242 Deprecate S5042 #5610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dorian-burihabwa-sonarsource merged 1 commit into from
May 8, 2026
Merged

SONARJAVA-6242 Deprecate S5042 #5610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions its/autoscan/src/test/resources/autoscan/autoscan-diff-by-rules.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1991,12 +1991,6 @@
"falseNegatives": 0,
"falsePositives": 0
},
{
"ruleKey": "S5042",
"hasTruePositives": true,
"falseNegatives": 8,
"falsePositives": 0
},
{
"ruleKey": "S5122",
"hasTruePositives": true,
Expand Down
6 changes: 0 additions & 6 deletions its/autoscan/src/test/resources/autoscan/diffs/diff_S5042.json
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S5042.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<p>This rule is deprecated, and will eventually be removed.</p>
<p>Successful Zip Bomb attacks occur when an application expands untrusted archive files without controlling the size of the expanded data, which can
lead to denial of service. A Zip bomb is usually a malicious archive file of a few kilobytes of compressed data but turned into gigabytes of
uncompressed data. To achieve this extreme <a href="https://en.wikipedia.org/wiki/Data_compression_ratio">compression ratio</a>, attackers will
Expand Down
2 changes: 1 addition & 1 deletion sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S5042.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
},
"attribute": "COMPLETE"
},
"status": "ready",
"status": "deprecated",
"remediation": {
"func": "Constant\/Issue",
"constantCost": "10min"
Expand Down
1 change: 0 additions & 1 deletion ...va-plugin/src/main/resources/org/sonar/l10n/java/rules/java/Sonar_agentic_AI_profile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,6 @@
"S4830",
"S4970",
"S4973",
"S5042",
"S5122",
"S5164",
"S5247",
Expand Down
1 change: 0 additions & 1 deletion sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/Sonar_way_profile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,6 @@
"S4970",
"S4973",
"S4977",
"S5042",
"S5122",
"S5164",
"S5247",
Expand Down
2 changes: 1 addition & 1 deletion sonar-java-plugin/src/test/java/org/sonar/plugins/java/JavaAgenticWayProfileTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ void profile_is_registered_as_expected() {
BuiltInQualityProfilesDefinition.BuiltInQualityProfile actualProfile = profilesPerLanguages.get("java").get("Sonar agentic AI");
assertThat(actualProfile.isDefault()).isFalse();
assertThat(actualProfile.rules())
.hasSize(468)
.hasSize(467)
.extracting(BuiltInQualityProfilesDefinition.BuiltInActiveRule::ruleKey)
.doesNotContainAnyElementsOf(List.of(
"S101",
Expand Down
Loading