Update context.me

[SharonStrats]

When researching an issue we are having with PATCH on the profile card resource, creating lots of logs led to exposing the following small bug.

Note: this did not fix the PATCH issue.

The logs showed the login flow actually entering ensureLoggedIn() and then ensureLoadedProfile(), and they exposed a race where authn.currentUser() was already available but context.me was still empty. So I have added a saveuser call to refresh the context.

[Copilot]

🟡 Changes recommended

The newly introduced login/profile race-handling paths are not covered by existing unit tests, increasing the risk of regressions in authentication flow.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR addresses a login/profile-loading race by ensuring the authenticated user is saved into the AuthenticationContext when a session is already active, so downstream code relying on context.me can proceed reliably.

Changes:

• Call authn.saveUser() when authn.checkUser() indicates an existing logged-in session.
• In ensureLoadedProfile(), resolve the WebID via context.me or authn.currentUser(), and backfill context.me when missing before loading the profile.

File summaries

File	Description
src/login/login.ts	Ensures the auth context is populated from existing sessions/current user to avoid context.me being empty during profile load.

Review details

Suppressed comments (1)

src/login/login.ts:209

• ensureLoadedProfile now falls back to authn.currentUser() and conditionally calls authn.saveUser() to populate context.me; this race-condition behavior change is not covered by tests. Please add a unit test that exercises the scenario where ensureLoggedIn resolves but context.me is still unset while authn.currentUser() returns a user, and assert that the profile load uses that resolved user and updates context accordingly.

    const logInContext = await ensureLoggedIn(context)
    const resolvedMe = logInContext.me || authn.currentUser()
    if (!resolvedMe) {
      throw new Error('Could not log in')
    }
    if (!logInContext.me) {
      authn.saveUser(resolvedMe as any, context)
    }
    context.publicProfile = await loadProfile(resolvedMe)

• Files reviewed: 1/2 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.