Skip to content

fix 403 error - #759

Open
SharonStrats wants to merge 3 commits into
stagingfrom
fix/403-error
Open

fix 403 error#759
SharonStrats wants to merge 3 commits into
stagingfrom
fix/403-error

Conversation

@SharonStrats

@SharonStrats SharonStrats commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

I just confirmed this is no longer needed to fix the PATCH issue, but it does remove the 403 errors.

Want to speak to Timea first about this.

…@5.0.0-1 pane-registry@5.0.0-0 activitystreams-pane@2.0.0-0 chat-pane@4.0.0-0 contacts-pane@4.0.0-0 folder-pane@4.0.0-0 issue-pane@4.0.0-0 meeting-pane@4.0.0-0 profile-pane@4.0.0-0 source-pane@4.0.0-0) (latest: rdflib@2.4.0)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new fallback introduces inconsistent use of DEFAULT_PROFILE_PATH, misleading indentation, and an inaccurate error message that can hinder debugging.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR adjusts WebID/profile resolution logic to avoid relying on a “default profile at pod root” assumption (likely related to the reported 403), and introduces a new fallback that tries loading the root-origin profile card.

Changes:

  • Removes the initial “pod root + DEFAULT_PROFILE_PATH” load attempt from both loadProfileFromURI and getNameOfPodOwner.
  • Adds a new fallback that tries ${origin}/profile/card#me when there is no first path segment to derive a prefixed pod from.
File summaries
File Description
src/utils/webIdUtils.ts Updates WebID/profile discovery fallbacks to prefer derived or origin-root profile card loading.
Review details

Suppressed comments (1)

src/utils/webIdUtils.ts:85

  • This catch covers failures from both the derived-profile attempt and the new rootWebId fallback, but the log message still says "failed on derived profile". Updating the message avoids misleading diagnostics when the root-profile load is what fails.
      return getName(store, rootWebId)
  } catch (err) {
    if (!isFetchErrorStatus(err, 403)) {
      console.error('getNameOfPodOwner failed on derived profile:', err)
    }
  • Files reviewed: 1/2 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/utils/webIdUtils.ts
Comment on lines +27 to +29
const rootWebId = sym(`${uriUrl.origin}/profile/card#me`)
await store.fetcher.load(rootWebId)
return rootWebId
Comment thread src/utils/webIdUtils.ts
Comment on lines +79 to +81
const rootWebId = sym(`${uriUrl.origin}/profile/card#me`)
await store.fetcher.load(rootWebId)
return getName(store, rootWebId)
…@5.0.0-1 pane-registry@5.0.0-0 activitystreams-pane@2.0.0-0 chat-pane@4.0.0-0 contacts-pane@4.0.0-0 folder-pane@4.0.0-0 issue-pane@4.0.0-0 meeting-pane@4.0.0-0 profile-pane@4.0.0-0 source-pane@4.0.0-0) (latest: rdflib@2.4.0)
@SharonStrats SharonStrats self-assigned this Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants