refresh uneditable doc - #449
Open
SharonStrats wants to merge 4 commits into
Open
Conversation
…@5.0.0-1 pane-registry@5.0.0-0 chat-pane@4.0.0-0) (latest: rdflib@2.4.0)
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new refresh logic currently triggers even when updater.editable is absent and uses broad any casts, which can introduce unintended network calls and weakens type-safety.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds a best-effort document refresh step during RDF update operations to handle cases where, after session restore, the store lacks enough metadata for rdflib to determine editability/protocol details.
Changes:
- Refreshes the target
docvia the store fetcher whenupdater.editable(...)cannot determine editability (returnsundefined). - Keeps the update flow resilient by swallowing refresh failures and continuing with the normal mutation path.
File summaries
| File | Description |
|---|---|
src/sections/shared/rdfMutationHelpers.ts |
Adds a pre-update refresh step to improve behavior when editability/protocol metadata is missing after session restoration. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…@5.0.0-1 pane-registry@5.0.0-0 chat-pane@4.0.0-0) (latest: rdflib@2.4.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code is needed to refresh the doc when the sessionRestore happens and the resource does not have all the correct metadata to be edittable.
Patch does not work without this code and also the code in solid-logic. The solid-logic code happens first to clear the data completely so that then this refresh will work.