fix(🐛): swap the skew shear axes in the native recorder too - #4020
Merged
wcandillon merged 2 commits intoAug 23, 2026
Merged
Conversation
Shopify#4015 fixed processTransform3d but missed the C++ mirror of it in the native recorder, which builds the same matrix for transform props with the same two axes swapped. The SkM44 constructor reads its arguments row-major, so skewX has to put tan(angle) in row 0 - exactly like the TypeScript version it shadows. Since the snapshots were regenerated for the corrected behaviour, native now disagrees with them and Transforms.spec fails on main for both test-android and build-test-ios-graphite.
wcandillon
self-requested a review
August 22, 2026 16:44
Contributor
|
🎉 This PR is included in version 2.11.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4015 — that PR is why
mainis currently red.What went wrong
#4015 fixed
skewX/skewYinprocessTransform3d, but the native recorder keeps its own copy of that conversion incpp/api/recorder/Convertor.h, and that copy has the same two axes swapped. Only the TypeScript side was corrected, so the two backends now disagree.The snapshots were regenerated for the corrected behaviour, so native is the one that fails. On
maintoday:build-test-ios-graphite(run)Transforms.spec.tsx— both skew tests fail, 167673 px difftest-android(on open PRs, which merge withmain)The fix
SkM44’s constructor reads its arguments in row-major order — the same layout as theMatrix4tuple in TypeScript. So the two argument lists are now literally identical to the arrays inMatrix4.ts:The
perspectivecase a few lines below is a useful control: its C++ argument list already matches the TypeScript array element for element, and its snapshot passes on native — which is what confirms the constructor convention.Testing
No new test:
Transforms.spec.tsxalready covers both axes and already fails onmain, sotest-androidandbuild-test-ios-graphitegoing green here is the verification. I have no local Skia build, so I could not run the native path myself — CI is the check.Sorry for the breakage.