fix(馃悰): accept booleans in Font.setSubpixel and Font.setEmbolden - #4011
Open
arnovanliere wants to merge 2 commits into
Open
fix(馃悰): accept booleans in Font.setSubpixel and Font.setEmbolden#4011arnovanliere wants to merge 2 commits into
arnovanliere wants to merge 2 commits into
Conversation
Both are declared as `(value: boolean) => void` in the TypeScript API, and
the CanvasKit backend forwards the boolean straight through. On native they
were bound with a `double` parameter, so `JSIConverter<double>` called
`asNumber()` on the argument and a real boolean threw:
Exception in HostFunction: Value is true, expected a number
Binding them as `bool` routes through `JSIConverter<bool>`, which uses
`asBool()`, matching the two neighbouring boolean setters
(`setEmbeddedBitmaps` and `setLinearMetrics`) and the declared API.
The `double` parameters date back to the typed-bindings migration (Shopify#3965),
which preserved the previous `asNumber()` behaviour so as not to change
semantics in a mechanical refactor. That kept the JS API unusable on native
without casting the argument to a number.
Author
|
I have signed the CLA! |
wcandillon
self-requested a review
August 22, 2026 09:13
wcandillon
approved these changes
Aug 22, 2026
wcandillon
left a comment
wcandillon
left a comment
Contributor
There was a problem hiding this comment.
Thank You for catching this :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both are declared as
(value: boolean) => voidin the TypeScript API, and the CanvasKit backend forwards the boolean straight through. On native they were bound with adoubleparameter, soJSIConverter<double>calledasNumber()on the argument and a real boolean threw:Binding them as
boolroutes throughJSIConverter<bool>, which usesasBool(), matching the two neighbouring boolean setters (setEmbeddedBitmapsandsetLinearMetrics) and the declared API.The
doubleparameters date back to the typed-bindings migration (#3965), which preserved the previousasNumber()behaviour so as not to change semantics in a mechanical refactor. That kept the JS API unusable on native without casting the argument to a number.