Cannot implicitly convert type 'AdvancedSharpAdbClient.Models.Framebuffer' to 'System.Drawing.Image'

[luronumen]

Describe the bug

It is not possible convert implicitly convert type 'AdvancedSharpAdbClient.Models.Framebuffer' to 'System.Drawing.Image' when build using .NET 8.0.

Steps to reproduce the bug

Try implicitly convert type 'AdvancedSharpAdbClient.Models.Framebuffer' to 'System.Drawing.Image' using 'AdvancedSharpAdbClient for .NET 8.0:

var deviceData = AdbClient.GetDevices().First(x => x.Serial == serial);
var adbClient = new AdbClient();
var image = (Image)adbClient.GetFrameBuffer(deviceData);

Expected behavior

It should be possible convert implicitly convert type 'AdvancedSharpAdbClient.Models.Framebuffer' to 'System.Drawing.Image' like it is possible to do when build using .NET Framework 4.8.1.

Screenshots

NuGet package version

3.1.10

.NET Platform

.NET 8

Platform type

Windows

System version

Windows 11 x64

IDE

Visual Studio 2022

Additional context

This issue is NOT reproducible when build using .NET Framework 4.8.1.

[wherewhere]

Because it need System.Drawing.Common and I removed it because it only supports Windows since .NET 7. You can change target to net8.0-windows10.0.17763.0.

[luronumen]

Hi @wherewhere

Thank you very much for your prompt reply!

I have replaced:

<TargetFramework>net8.0-windows</TargetFramework>

by:

<TargetFramework>net8.0-windows10.0.17763.0</TargetFramework>

And this issue is not reproducible.

Is there any plan to remove System.Drawing.Common dependency once that it is now Windows Only?

Thanks in advanced,
Luciano

[wherewhere]

But System.Drawing.Common is a part of desktop extension. .net-windows does not contains it...

[luronumen]

But System.Drawing.Common is a part of desktop extension. .net-windows does not contains it...

If so, why not support the System.Drawing.Common for net8.0-windows fully instead of net8.0-windows10.0.17763.0 only if it is part of desktop extension?

[wherewhere]

Because I also add the supports for WinRT like this:
https://github.com/SharpAdb/AdvancedSharpAdbClient/blob/main/AdvancedSharpAdbClient/SyncService.Async.cs#L205-L379

[wherewhere]

You can create an extension with this codes by yourself.
https://github.com/SharpAdb/AdvancedSharpAdbClient/blob/main/AdvancedSharpAdbClient%2FModels%2FFramebufferHeader.cs#L270-L418

[wherewhere]

https://gist.github.com/wherewhere/bcbab80a9460aad8fd14655c15c76cba

[luronumen]

https://gist.github.com/wherewhere/bcbab80a9460aad8fd14655c15c76cba

Hi @wherewhere

Do you have any plan to add this implementation in the next AdvancedSharpAdbClient package to make it is possible to convert the Framebuffer to System.Drawing.Image on net8.0-windows?

Thanks in advance,
Luciano

[wherewhere]

No

[luronumen]

No

If so, could you please update the README documentation to say that this is not working when use the net8.0-windows as TargetFramework:

https://github.com/SharpAdb/AdvancedSharpAdbClient#getting-a-screenshot

[wherewhere]

https://github.com/SharpAdb/AdvancedSharpAdbClient/wiki/Compatibility

[ArrogantDonkey]

我获取到他的历史版本，有这个写法，可以将FrameBuffer转成System.Drawing.Image

/// <summary>
/// 
/// </summary>
/// <param name="frameBuffer"></param>
/// <returns></returns>
/// <exception cref="ArgumentNullException"></exception>
public static Image ToImage(this Framebuffer frameBuffer)
{
    var header = frameBuffer.Header;
    var buffer = frameBuffer.Data;
    if (buffer == null)
    {
        throw new ArgumentNullException("buffer");
    }
    var Width = header.Width;
    var Height = header.Height;
    var Bpp = header.Bpp;
    var size = header.Size;
    if (Width == 0 || Height == 0 || Bpp == 0)
    {
        return null;
    }

    PixelFormat val = StandardizePixelFormat(header, buffer);
    Bitmap val2 = new Bitmap((int)Width, (int)Height, val);
    BitmapData val3 = val2.LockBits(new Rectangle(0, 0, ((Image)val2).Width, ((Image)val2).Height), (ImageLockMode)2, val);
    Marshal.Copy(buffer, 0, val3.Scan0, (int)size);
    val2.UnlockBits(val3);
    return (Image)(object)val2;
}

private static PixelFormat StandardizePixelFormat(FramebufferHeader header, byte[] buffer)
{
    var Width = header.Width;
    var Height = header.Height;
    var Bpp = header.Bpp;
    var size = header.Size;
    var Red = header.Red;
    var Blue = header.Blue;
    var Green = header.Green;
    var Alpha = header.Alpha;
    var Size = header.Size;

    if (buffer == null)
    {
        throw new ArgumentNullException("buffer");
    }

    if (buffer.Length < Width * Height * (Bpp / 8))
    {
        throw new ArgumentOutOfRangeException("buffer", $"The buffer length {buffer.Length} is less than expected buffer " + $"length ({Width * Height * (Bpp / 8)}) for a picture of width {Width}, height {Height} and pixel depth {Bpp}");
    }

    if (Width == 0 || Height == 0 || Bpp == 0)
    {
        throw new InvalidOperationException("Cannot caulcate the pixel format of an empty framebuffer");
    }

    if (Bpp == 32)
    {
        if (Red.Length != 8 || Blue.Length != 8 || Green.Length != 8)
        {
            throw new ArgumentOutOfRangeException($"The pixel format with with RGB lengths of {Red.Length}:{Blue.Length}:{Green.Length} is not supported");
        }

        uint length = Alpha.Length;
        if (length != 0 && length != 8)
        {
            throw new ArgumentOutOfRangeException($"The alpha length {Alpha.Length} is not supported");
        }

        uint num = Red.Offset / 8;
        uint num2 = Blue.Offset / 8;
        uint num3 = Green.Offset / 8;
        uint num4 = Alpha.Offset / 8;
        for (int i = 0; i < (int)Size; i += 4)
        {
            byte b = buffer[i + num];
            byte b2 = buffer[i + num2];
            byte b3 = buffer[i + num3];
            byte b4 = buffer[i + num4];
            if (Alpha.Length == 8)
            {
                buffer[i + 3] = b4;
                buffer[i + 2] = b;
                buffer[i + 1] = b3;
                buffer[i] = b2;
            }
            else
            {
                buffer[i + 3] = b;
                buffer[i + 2] = b3;
                buffer[i + 1] = b2;
                buffer[i] = 0;
            }
        }

        if (Alpha.Length == 0)
        {
            return (PixelFormat)139273;
        }

        return (PixelFormat)2498570;
    }

    if (Bpp == 24)
    {
        if (Red.Offset == 0 && Red.Length == 8 && Green.Offset == 8 && Green.Length == 8 && Blue.Offset == 16 && Blue.Length == 8 && Alpha.Offset == 24 && Alpha.Length == 0)
        {
            return (PixelFormat)137224;
        }
    }
    else if (Bpp == 16 && Red.Offset == 11 && Red.Length == 5 && Green.Offset == 5 && Green.Length == 6 && Blue.Offset == 0 && Blue.Length == 5 && Alpha.Offset == 0 && Alpha.Length == 0)
    {
        return (PixelFormat)135174;
    }

    throw new NotSupportedException($"Pixel depths of {Bpp} are not supported");
}